Repository navigation
fix(agent): frame intent summaries as data (issue #124) - #311
Merged
Merged
Conversation
The wake lines interpolated a planner-written intent summary into the trusted sentence, and the overview kept every summary in the plain JSON, so an inherited summary crossed tasks as if this planner had written it (#124, F3). Frame the summary on the wake lines and move the open/running/recent-done summaries into one framed block; the structured intent fields stay plain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent summaries are planner-written text, but they reached the planner in two trusted places (#124, F3):
The worker of intent #N (<summary>) ...outside the data envelope;graph_overviewkeptopen_intents/running_intents/recent_done_intentsin the plain JSON, andcompactIntentsmarks inherited nodes withsource_task_id/inherited, so a summary written by another task's planner arrived as if this planner had written it.This change keeps the structured intent fields plain (id, state, asset_ids, parents, yields, inherited flags) and moves every summary into one framed block (
field=intent_summaries), with the id and the inherited origin inside. The wake lines render the summary in its own frame (field=intent_summary) instead of interpolating it into the sentence.Tests:
TestDataEnvelopeFramesIntentSummariesandTestDataEnvelopeFramesWakeIntentSummaryassert the summaries appear only inside a frame and the structured fields stay plain;TestWorkerOverviewEnvelopeSplitis updated for the new split.go test ./agentpasses locally (the Postgres-backed tests skip and run in CI).Not in this change: the declared-vs-derived provenance of
record_fact, the other residual in #124, which needs a rule for facts that can be tied to proxy-captured traffic.