Update bookmarks in .cls file to use normal casing#23
Merged
Conversation
…atch the rest of the bookmarks in the document.
Collaborator
|
@tmclainut This proposed change from a student changes the capitalization of the PDF bookmarks in the front matter from all caps to title case to match the other sections. Is this fine? |
Collaborator
|
Yes, definitely. Makes sense to me.
From: Jeff Goeders ***@***.***>
Date: Saturday, April 4, 2026 at 10:22 AM
To: BYU-Engineering/thesis_template ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [BYU-Engineering/thesis_template] Update bookmarks in .cls file to use normal casing (PR #23)
[https://avatars.githubusercontent.com/u/1851142?s=20&v=4]jgoeders left a comment (BYU-Engineering/thesis_template#23)<#23 (comment)>
@tmclainut<https://github.com/tmclainut> This proposed change from a student changes the capitalization of the PDF bookmarks in the front matter from all caps to title case to match the other sections. Is this fine?
—
Reply to this email directly, view it on GitHub<#23 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATGDTCTSE3DSHAUBN66JLAT4UEZB3AVCNFSM6AAAAACXME5ADOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCOBXGM2DSMRYHE>.
You are receiving this because you are subscribed to this thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bookmarks for title pages, abstract, and acknowledgements were in all caps. This does not match the bookmarks for table of contents and chapters. This makes all bookmark titles in the document uniform.