Repository navigation
Add shared workflow checks and the workflow convention - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every workflow in the studio's repositories now follows one written convention,
docs/workflows.md, and a reusable workflow enforces it..github/workflows/shared-checks.yml(called from each repository'schecks.yml):Workflowsruns actionlint, zizmor (with every action required to be pinned by commit SHA) andscripts/check-workflows.mjsover the repository's workflows and composite actions.Dependenciesreviews new and changed dependencies for known vulnerabilities and for licences outside the allow-list, in repositories that setdependency-review: true..github/actions/workflow-checks, which the shared workflow reaches through the$/self-repository syntax, so tools, configuration and workflow always come from the same commit. actionlint and zizmor run from digest-pinned container images that Renovate keeps current.scripts/check-workflows.mjscovers the parts of the convention no other tool checks: key order, permissions, concurrency,bashas the shell, job names and timeouts, step layout,ifconditions, expressions insiderun, spacing and quoting. It is dependency-free and tested withnode:test.test.ymlfollows the convention.