completly removed the NA_treatment variable from the config#28
Closed
claude-marie wants to merge 2 commits intomainfrom
Closed
completly removed the NA_treatment variable from the config#28claude-marie wants to merge 2 commits intomainfrom
claude-marie wants to merge 2 commits intomainfrom
Conversation
- Remove legacy NA_TREATMENT field from SNT_config.json files (COD, NER, BFA) - Add new 0_VALUES_PRESERVED boolean field to specify DHIS2 instance config - Add documentation comments in reporting rate notebooks explaining the change - See ticket: SNT25-158
Collaborator
|
apparently there are some conflicts with the main. You can include your changes to the latest version of code/snt_dhis2_reporting_rate_dataelement.ipynb that is currently in the main, and push it again. Other than that, we're good to merge👍 |
Contributor
Author
|
merged using main directly to avoid merge conflit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the na_treatment variable was legacy code and wasn't not used aside from 2 R notebook where it was declared but not use.
At first we replaced it with a boolean like 0_VALUES_PRESERVED but after discussion with the team it seems no one is using this variable and was suggested by the data scientist to remove it completly so I did.
Frederick agreed with the full remove :)
ticket:
https://bluesquare.atlassian.net/browse/SNT25-158