Tolerate batterydf main's read() signature in ws.convert - #366
Open
jsimonclark wants to merge 1 commit into
Open
Tolerate batterydf main's read() signature in ws.convert#366jsimonclark wants to merge 1 commit into
jsimonclark wants to merge 1 commit into
Conversation
batterydf main dropped the lazy= kwarg from bdf.read() (read is always eager now; scan() is the lazy path), so ws.convert() failed with 'read() got an unexpected keyword argument lazy' against a main install. Found converting a Neware .ndax in the 0.8 publication rehearsal. Sniff the signature: pass lazy=False only when the installed batterydf accepts it (older builds default to a LazyFrame and need it), omit it on current main. Both directions verified: the pinned rev still passes the full suite, and .ndax -> BDF conversion works against batterydf main.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
_read_bdf_pandassniffsbdf.read's signature and passeslazy=Falseonly when the installed batterydf accepts it.Why
batterydf main dropped the
lazy=kwarg (read() is always eager; scan() is the lazy path), sows.convert()failed withread() got an unexpected keyword argument 'lazy'against a batterydf main install. Found converting a Neware .ndax during the 0.8 publication rehearsal. Since batterydf 0.2.0 will release from main, battinfo must work with both the pinned rev and main.How
One call site (
processing.py) funnels every bdf.read use, including the interop battdat path.inspect.signaturegates the kwarg; older builds keeplazy=False(their default returns a LazyFrame), newer builds get a plain call.Testing
Full suite green against the pinned rev (2060 passed); .ndax → BDF conversion verified working against batterydf main in a clean venv. ruff clean.