Remove check for log description to capture empty boreholes#3573
Merged
pawelbaran merged 2 commits intodevelopfrom Mar 20, 2026
Merged
Remove check for log description to capture empty boreholes#3573pawelbaran merged 2 commits intodevelopfrom
pawelbaran merged 2 commits intodevelopfrom
Conversation
peterjamesnugent
requested review from
FraserGreenroyd and
IsakNaslundBh
as code owners
Member
Author
|
@BHoMBot check installer |
|
@peterjamesnugent to confirm, the following actions are now queued:
|
EmmaMcGugan
approved these changes
Mar 16, 2026
EmmaMcGugan
previously approved these changes
Mar 19, 2026
EmmaMcGugan
left a comment
EmmaMcGugan
left a comment
There was a problem hiding this comment.
Tested using provided script and works as intended.
… and GEOL_GEOL data which is useful downstream
EmmaMcGugan
approved these changes
Mar 20, 2026
EmmaMcGugan
left a comment
EmmaMcGugan
left a comment
There was a problem hiding this comment.
Tested using provided script and works as intended
Member
Author
|
@BHoMBot check ready-to-merge |
|
@peterjamesnugent to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #3572
Test files
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM_Engine/Ground_Engine/%233573-BoreholeWithNoLog/%233572-BoreholeWithNoLong.gh?csf=1&web=1&e=jkaHzp
Changelog
LogDescription.Additional comments