Add Codex parity tooling#154
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Storybook Component Screenshot PreviewOutcome: success Screenshots: primitive component stories captured on desktop and mobile. This lane is separate from full-route Playwright screenshots and focuses on design-system component regressions. |
Storybook Image DiffOutcome: success Changed Storybook baselines: none in this PR. This check compares design-system component screenshots against committed baselines. Inline images show only added or modified Storybook baseline PNGs. |
Greptile SummaryThis PR adds Codex parity tooling and protected-main workflow guards. The main changes are:
Confidence Score: 4/5The workflow guard additions are mostly isolated, but one Codex skill wrapper references a missing source file and should be fixed before relying on the new VRCDN onboarding path. The changed files are primarily configuration, package scripts, and documentation wrappers, with a narrow tooling failure confirmed around the VRCDN skill reference. .codex/skills/vrcdn/SKILL.md
What T-Rex did
|
|
|
||
| - `.opencode/skills/vrcdn/SKILL.md` |
There was a problem hiding this comment.
Missing source skill
This wrapper routes Codex to .opencode/skills/vrcdn/SKILL.md, but the repository has no .opencode/skills/**/SKILL.md files. Opening the new Codex skill leads agents to a missing source of truth, so the wrapper cannot provide the advertised VRCDN guidance.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .codex/skills/vrcdn/SKILL.md
Line: 9-10
Comment:
**Missing source skill**
This wrapper routes Codex to `.opencode/skills/vrcdn/SKILL.md`, but the repository has no `.opencode/skills/**/SKILL.md` files. Opening the new Codex skill leads agents to a missing source of truth, so the wrapper cannot provide the advertised VRCDN guidance.
How can I resolve this? If you propose a fix, please make it concise.
Playwright Hosted Data-FlowOutcome: success This optional check runs the mutation-backed profile flow against a configured hosted dev/staging target with isolated E2E test data. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f6a1b37eac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const scriptDir = path.dirname(fileURLToPath(import.meta.url)); | ||
| const repoRoot = path.resolve(scriptDir, ".."); | ||
|
|
||
| if (process.env.CI === "true" || process.env.GITHUB_ACTIONS === "true") { |
There was a problem hiding this comment.
Accept CI=1 before blocking Vercel builds
This bypass only treats CI as the literal string true, but Vercel build environments set CI=1, and this commit adds prebuild hooks to the web/docs Vercel build paths. On a production deployment from a main checkout, the guard will continue past this check and fail at the branchName === "main" block, so pnpm build:vercel/pnpm build can be blocked in Vercel instead of only protecting local mirrors; consider accepting any non-empty CI or VERCEL=1.
Useful? React with 👍 / 👎.
| args = ["convex", "mcp", "start", "--project-dir", "."] | ||
|
|
||
| [mcp_servers.aws_docs] | ||
| command = "C:/Users/steve/.local/bin/uvx.exe" |
There was a problem hiding this comment.
Use portable MCP commands in project config
The new Codex docs describe .codex/config.toml as project-scoped repo config, but this command points at one Windows user's home directory; any contributor or agent on Linux, macOS, or another Windows account will fail to spawn the AWS docs/IaC MCP servers, with the same pattern repeated for Daytona below. Use PATH-resolved commands like uvx/daytona or keep personal absolute paths in local config instead.
Useful? React with 👍 / 👎.
Playwright Public Screenshot PreviewOutcome: success Screenshots: all public route checks passed on desktop and mobile. Full screenshot set is available in the artifact. Pixel diff baselines are handled by the separate Playwright Image Diff check. |
Playwright Image DiffOutcome: success Changed screenshot baselines: none in this PR. This check compares public route screenshots against committed baselines. Inline images show only added or modified baseline PNGs. |
Playwright Data-Flow PreviewOutcome: success Captured flow:
Artifacts include screenshots, traces, and recorded video for the flow run. |
Vercel Preview DeploymentPreview: https://vr-dex-56p3do3ox-basicbit.vercel.app |
Summary
Verification