Skip to content

Add Codex parity tooling#154

Open
BASIC-BIT wants to merge 1 commit into
mainfrom
codex/codex-parity-tooling
Open

Add Codex parity tooling#154
BASIC-BIT wants to merge 1 commit into
mainfrom
codex/codex-parity-tooling

Conversation

@BASIC-BIT

Copy link
Copy Markdown
Owner

Summary

  • add repo-local Codex MCP config and thin Codex skill wrappers for VRDex onboarding and VRCDN workflows
  • document Codex-specific workflow notes, tool mapping, and protected worktree policy
  • add protected-main guard hooks to root and workspace package scripts

Verification

  • node -e package JSON parse check for root, web, docs, and discord-gateway package files
  • node --check scripts/guard-main-worktree.mjs
  • D:\bench\VRDex\node_modules.bin\markdownlint-cli2
  • git diff --check HEAD~1..HEAD

@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vr-dex-web Ready Ready Preview, Comment Jun 25, 2026 1:23pm

Request Review

@github-actions

Copy link
Copy Markdown

Storybook Component Screenshot Preview

Outcome: success
Run: https://github.com/BASIC-BIT/VRDex/actions/runs/28173292133
Artifact: storybook-component-preview

Screenshots: primitive component stories captured on desktop and mobile.

This lane is separate from full-route Playwright screenshots and focuses on design-system component regressions.

@github-actions

Copy link
Copy Markdown

Storybook Image Diff

Outcome: success
Run: https://github.com/BASIC-BIT/VRDex/actions/runs/28173292133
Artifact: storybook-image-diff

Changed Storybook baselines: none in this PR.

This check compares design-system component screenshots against committed baselines. Inline images show only added or modified Storybook baseline PNGs.

@greptile-apps

greptile-apps Bot commented Jun 25, 2026

Copy link
Copy Markdown

Greptile Summary

This PR adds Codex parity tooling and protected-main workflow guards. The main changes are:

  • Repo-local Codex MCP configuration for Playwright, Vercel, Convex, AWS, and Daytona tools.
  • Thin Codex skill wrappers for VRCDN and VRDex onboarding workflows.
  • Codex-specific agent documentation for MCP usage, skill mapping, and protected worktrees.
  • Protected-main guard lifecycle hooks across root, web, docs, and Discord gateway package scripts.
  • A Node guard script that blocks local workflow commands on main unless CI or an explicit bypass is active.

Confidence Score: 4/5

The workflow guard additions are mostly isolated, but one Codex skill wrapper references a missing source file and should be fixed before relying on the new VRCDN onboarding path.

The changed files are primarily configuration, package scripts, and documentation wrappers, with a narrow tooling failure confirmed around the VRCDN skill reference.

.codex/skills/vrcdn/SKILL.md

T-Rex T-Rex Logs

What T-Rex did

  • Validated a missing source skill condition by running a repo-local Node validation script that reads .codex/skills/vrcdn/SKILL.md and confirms it references .opencode/skills/vrcdn/SKILL.md; the validation failed because the referenced source skill does not exist on disk.
  • Inspected the protected-main guard workflow by comparing before and after artifacts, confirming that prehooks were added and that the main guard exits and non-main CI paths behaved as described.
  • Reviewed the Codex parity run by comparing before and after parity artifacts, identifying an MCP server name contract failure and listing missing MCP sections such as chrome-devtools, context7, and sequential-thinking.

View all artifacts

T-Rex Ran code and verified through T-Rex

Comments Outside Diff (1)

  1. General comment

    P1 Codex config omits documented MCP server names

    • Bug
      • The claimed Codex parity contract expects .codex/config.toml to expose the documented project MCP server names chrome-devtools, context7, playwright, and sequential-thinking. The executed head check parsed the actual [mcp_servers.*] sections and found only playwright, vercel_vrdex, convex, AWS-related entries, and daytona; chrome-devtools, context7, and sequential-thinking are missing.
    • Cause
      • The MCP server entries added to .codex/config.toml do not match the documented/validated server-name contract.
    • Fix
      • Update .codex/config.toml so its [mcp_servers.*] sections include the documented server names, at minimum [mcp_servers.chrome-devtools], [mcp_servers.context7], [mcp_servers.playwright], and [mcp_servers.sequential-thinking], or update the documentation/contract if these names are intentionally no longer valid.

    T-Rex Ran code and verified through T-Rex

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
.codex/skills/vrcdn/SKILL.md:9-10
**Missing source skill**
This wrapper routes Codex to `.opencode/skills/vrcdn/SKILL.md`, but the repository has no `.opencode/skills/**/SKILL.md` files. Opening the new Codex skill leads agents to a missing source of truth, so the wrapper cannot provide the advertised VRCDN guidance.

Reviews (1): Last reviewed commit: "Add Codex parity tooling" | Re-trigger Greptile

Comment on lines +9 to +10

- `.opencode/skills/vrcdn/SKILL.md`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Missing source skill
This wrapper routes Codex to .opencode/skills/vrcdn/SKILL.md, but the repository has no .opencode/skills/**/SKILL.md files. Opening the new Codex skill leads agents to a missing source of truth, so the wrapper cannot provide the advertised VRCDN guidance.

Prompt To Fix With AI
This is a comment left during a code review.
Path: .codex/skills/vrcdn/SKILL.md
Line: 9-10

Comment:
**Missing source skill**
This wrapper routes Codex to `.opencode/skills/vrcdn/SKILL.md`, but the repository has no `.opencode/skills/**/SKILL.md` files. Opening the new Codex skill leads agents to a missing source of truth, so the wrapper cannot provide the advertised VRCDN guidance.

How can I resolve this? If you propose a fix, please make it concise.

@github-actions

Copy link
Copy Markdown

Playwright Hosted Data-Flow

Outcome: success
Target: https://staging.vrdex.net
Hosted extended profile flow: enabled
Hosted auth helpers: enabled
Hosted adapter helpers: enabled
Run: https://github.com/BASIC-BIT/VRDex/actions/runs/28173292133
Artifact: playwright-hosted-data-flow

This optional check runs the mutation-backed profile flow against a configured hosted dev/staging target with isolated E2E test data.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f6a1b37eac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const scriptDir = path.dirname(fileURLToPath(import.meta.url));
const repoRoot = path.resolve(scriptDir, "..");

if (process.env.CI === "true" || process.env.GITHUB_ACTIONS === "true") {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Accept CI=1 before blocking Vercel builds

This bypass only treats CI as the literal string true, but Vercel build environments set CI=1, and this commit adds prebuild hooks to the web/docs Vercel build paths. On a production deployment from a main checkout, the guard will continue past this check and fail at the branchName === "main" block, so pnpm build:vercel/pnpm build can be blocked in Vercel instead of only protecting local mirrors; consider accepting any non-empty CI or VERCEL=1.

Useful? React with 👍 / 👎.

Comment thread .codex/config.toml
args = ["convex", "mcp", "start", "--project-dir", "."]

[mcp_servers.aws_docs]
command = "C:/Users/steve/.local/bin/uvx.exe"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use portable MCP commands in project config

The new Codex docs describe .codex/config.toml as project-scoped repo config, but this command points at one Windows user's home directory; any contributor or agent on Linux, macOS, or another Windows account will fail to spawn the AWS docs/IaC MCP servers, with the same pattern repeated for Daytona below. Use PATH-resolved commands like uvx/daytona or keep personal absolute paths in local config instead.

Useful? React with 👍 / 👎.

@github-actions

Copy link
Copy Markdown

Playwright Public Screenshot Preview

Outcome: success
Run: https://github.com/BASIC-BIT/VRDex/actions/runs/28173292133
Artifact: playwright-public-preview

Screenshots: all public route checks passed on desktop and mobile.

Full screenshot set is available in the artifact. Pixel diff baselines are handled by the separate Playwright Image Diff check.

@github-actions

Copy link
Copy Markdown

Playwright Image Diff

Outcome: success
Run: https://github.com/BASIC-BIT/VRDex/actions/runs/28173292133
Artifact: playwright-image-diff

Changed screenshot baselines: none in this PR.

This check compares public route screenshots against committed baselines. Inline images show only added or modified baseline PNGs.

@github-actions

Copy link
Copy Markdown

Playwright Data-Flow Preview

Outcome: success
Run: https://github.com/BASIC-BIT/VRDex/actions/runs/28173292133
Artifact: playwright-data-flow

Captured flow:

  • test-gated profile submission form
  • gated helper rejection without the Playwright token
  • Convex profile creation
  • submission success state
  • public profile page readback
  • discovery search readback

Artifacts include screenshots, traces, and recorded video for the flow run.

@github-actions

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant