fix build_info() reporting tiny_profile=False on TINY_PROFILE-on builds#268
Merged
jameslehoux merged 1 commit intomasterfrom May 2, 2026
Merged
fix build_info() reporting tiny_profile=False on TINY_PROFILE-on builds#268jameslehoux merged 1 commit intomasterfrom
jameslehoux merged 1 commit intomasterfrom
Conversation
oi.build_info() was reporting "TinyProfile: False" on the openimpala-cuda
4.2.9 wheel, even though the AMReX dep was built with
-DAMReX_TINY_PROFILE=ON. The reason: AMReX's CMake option name and the
compile-definition it emits are different.
AMReXSetDefines.cmake:37
add_amrex_define( AMREX_TINY_PROFILING NO_LEGACY IF AMReX_TINY_PROFILE )
So with the option ON, the macro AMReX puts on the AMReX::amrex
target's INTERFACE_COMPILE_DEFINITIONS is `AMREX_TINY_PROFILING`, not
`AMREX_TINY_PROFILE`. My #ifdef in module.cpp::build_info() was checking
the option name and so always evaluated false.
One-line fix: AMREX_TINY_PROFILE -> AMREX_TINY_PROFILING. The actual
runtime profiling instrumentation in AMReX (BL_PROFILE macros) and our
build settings are unchanged — this only affects what build_info()
reports.
https://claude.ai/code/session_011dJ5Bwq4Tnr8wxH597XJFf
Performance Benchmark Results
Fastest solver: bicgstab at 64³ (0.3733s) Benchmark: uniform block (analytical τ = (N-1)/N) |
Code Coverage ReportGenerated by CI — coverage data from gcovr |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oi.build_info() was reporting "TinyProfile: False" on the openimpala-cuda 4.2.9 wheel, even though the AMReX dep was built with -DAMReX_TINY_PROFILE=ON. The reason: AMReX's CMake option name and the compile-definition it emits are different.
AMReXSetDefines.cmake:37
add_amrex_define( AMREX_TINY_PROFILING NO_LEGACY IF AMReX_TINY_PROFILE )
So with the option ON, the macro AMReX puts on the AMReX::amrex target's INTERFACE_COMPILE_DEFINITIONS is
AMREX_TINY_PROFILING, notAMREX_TINY_PROFILE. My #ifdef in module.cpp::build_info() was checking the option name and so always evaluated false.One-line fix: AMREX_TINY_PROFILE -> AMREX_TINY_PROFILING. The actual runtime profiling instrumentation in AMReX (BL_PROFILE macros) and our build settings are unchanged — this only affects what build_info() reports.