Skip to content

fix AMReXConfig.cmake unquoted variable expansion (real root cause) #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jameslehoux merged 1 commit into from
Apr 29, 2026
Merged

fix AMReXConfig.cmake unquoted variable expansion (real root cause) #265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/pypi-wheels-gpu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
uses: actions/cache@v4
with:
path: .cibw-deps-cache
key: cibw-deps-gpu-cuda12.6-manylinux_2_34-x86_64-hdf5_1.14.6-tiff_4.6.0-hypre_2.31.0-amrex_25.03-gcc13-nvtx3.1.1-arch75-80-archfix-v9
key: cibw-deps-gpu-cuda12.6-manylinux_2_34-x86_64-hdf5_1.14.6-tiff_4.6.0-hypre_2.31.0-amrex_25.03-gcc13-nvtx3.1.1-arch75-80-quotefix-v10

- name: Build GPU wheels
run: python -m cibuildwheel --output-dir wheelhouse
Expand Down Expand Up @@ -141,11 +141,14 @@ jobs:
-DCMAKE_CUDA_HOST_COMPILER=/opt/rh/gcc-toolset-13/root/usr/bin/g++ &&
cmake --build /tmp/amrex/build -j$(nproc) &&
cmake --install /tmp/amrex/build &&
sed -i 's|set(AMREX_CUDA_ARCHS CACHE INTERNAL|set(AMREX_CUDA_ARCHS "75;80" CACHE INTERNAL|' /usr/local/lib/cmake/AMReX/AMReXConfig.cmake &&
strip --strip-debug /usr/local/lib/libamrex_3d.a /usr/local/lib/libHYPRE.a /usr/local/lib/libhdf5*.a /usr/local/lib/libtiff.a 2>/dev/null || true &&
mkdir -p /project/.cibw-deps-cache &&
tar czf /project/.cibw-deps-cache/deps.tar.gz /usr/local ;
fi
fi &&
echo "=== Patching installed AMReXConfig.cmake (runs on cache hit AND miss) ===" &&
sed -i 's|set(AMREX_CUDA_ARCHS CACHE INTERNAL|set(AMREX_CUDA_ARCHS "75;80" CACHE INTERNAL|' /usr/local/lib/cmake/AMReX/AMReXConfig.cmake &&
sed -i 's|CUDA_ARCHITECTURES ${AMREX_CUDA_ARCHS})|CUDA_ARCHITECTURES "${AMREX_CUDA_ARCHS}")|' /usr/local/lib/cmake/AMReX/AMReXConfig.cmake &&
grep -n 'AMREX_CUDA_ARCHS' /usr/local/lib/cmake/AMReX/AMReXConfig.cmake

# Rename the package to openimpala-cuda and uncomment the nvidia-*-cu12
# runtime deps (kept commented in pyproject.toml so they don't pollute
Expand Down
Loading