[action] [PR:685] [BMC] Align get_presence for the new infra#114
Merged
Conversation
<!-- Provide a general summary of your changes in the Title above -->
#### Description
<!--
Describe your changes in detail
-->
- Updated `sonic_platform_base/bmc_base.py` to check:
- `device_info.is_switch_host()`
- `device_info.get_bmc_data()`
- Removed the older `bmc_addr`-only presence condition.
- Updated `tests/bmc_base_test.py` to match the new behavior:
- present on Switch-Host with bmc data
- not present when bmc data is missing
- not present on non-host even if bmc data exists
#### Motivation and Context
<!--
Why is this change required? What problem does it solve?
If this pull request closes/resolves an open Issue, make sure you
include the text "fixes #xxxx", "closes #xxxx" or "resolves #xxxx" here
-->
`BMCBase.get_presence()` was aligned with the new host/BMC split (sonic-net/sonic-buildimage#26544)
so BMC presence is reported only for Switch-Host platforms with runtime BMC data.
This avoids treating Switch-BMC side execution as BMC-present for host-only logic.
#### How Has This Been Tested?
<!--
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.
-->
- Run unit tests:
- `pytest tests/bmc_base_test.py`
- Validate platform API behavior manually:
- `bmc.get_presence()` returns `True` only on Switch-Host with valid `/etc/sonic/bmc.json`
- returns `False` on Switch-BMC side or when BMC data is unavailable
Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
#### Additional Information (Optional)
Collaborator
Author
|
Original PR: sonic-net/sonic-platform-common#685 |
Collaborator
Author
|
/azp run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
sonic_platform_base/bmc_base.pyto check:device_info.is_switch_host()device_info.get_bmc_data()bmc_addr-only presence condition.tests/bmc_base_test.pyto match the new behavior:Motivation and Context
BMCBase.get_presence()was aligned with the new host/BMC split (sonic-net/sonic-buildimage#26544)so BMC presence is reported only for Switch-Host platforms with runtime BMC data.
This avoids treating Switch-BMC side execution as BMC-present for host-only logic.
How Has This Been Tested?
pytest tests/bmc_base_test.pybmc.get_presence()returnsTrueonly on Switch-Host with valid/etc/sonic/bmc.jsonFalseon Switch-BMC side or when BMC data is unavailableSigned-off-by: Sonic Build Admin sonicbld@microsoft.com
Additional Information (Optional)