[action] [PR:26077] [loganalyzer] Ignore rsyslog-collapsed "collectData: Failed to get port attr" logs#1303
Merged
Conversation
…rt attr" logs
### Description of PR
Summary:
Fixes #24023
The LogAnalyzer ignore rule for the benign syncd `collectData: Failed to get port attr for VID ... RID ...: -<code>` error anchored on the literal substring `#syncd: :- collectData`. rsyslog deduplicates repeated identical lines into a summary of the form:
```
ERR syncd#syncd: message repeated N times: [ :- collectData: Failed to get port attr for VID 0x..., RID:0x...: -8]
```
Because `message repeated N times: [ ` sits between `#syncd:` and `:- collectData`, the rigid anchor does not match the collapsed line. LogAnalyzer then flags it and QoS SAI cases error on teardown (observed on Broadcom 7060x6 ft2/lt2 nightlies, e.g. `str4-7060x6-512-4`, image `20251110.38` — 14 QoS SAI teardown errors in a single nightly).
### Type of change
- [x] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
- [ ] Skipped for non-supported platforms
- [ ] Test case improvement
### Back port request
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505
- [x] 202511
- [x] 202512
- [ ] 202605
Tracking issue/work item for backport/cherry-pick request: #24023
Failure type: day-one issue (test infrastructure — the collapsed-log form was never covered by the ignore rule)
### Approach
#### What is the motivation for this PR?
Eliminate false-positive LogAnalyzer teardown failures on Broadcom 7060x6 nightlies. A previous fix generalized the error code (`-2` -> `-\d+`), but the rule still only matched the un-collapsed line, so rsyslog's `message repeated N times: [ ... ]` summary continued to trip LogAnalyzer and error the QoS SAI cases at teardown.
#### How did you do it?
Replaced the rigid `#syncd: :- collectData` anchor with `#syncd:.*collectData` in `loganalyzer_common_ignore.txt`, so both the direct and the rsyslog-collapsed forms are ignored. The rest of the pattern (VID/RID hex and `-\d+` error code) is unchanged, keeping the rule scoped to this specific benign error.
#### How did you verify/test it?
Validated the new regex against the exact lines from the failing nightly: it matches both the direct line and the `message repeated N times: [ ... ]` collapsed line, matches multi-asic `syncd0`, and does not match unrelated `collectData` errors.
#### Any platform specific information?
Broadcom 7060x6 (ft2/lt2 topologies). The SAI return code observed on this platform is `-8`; the log volume triggers rsyslog message collapsing.
#### Supported testbed topology if it's a new test case?
N/A — not a new test case.
### Documentation
N/A — no documentation change required.
Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
Collaborator
Author
|
Original PR: sonic-net/sonic-mgmt#26077 |
Collaborator
Author
|
/azp run |
12 tasks
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #24023
The LogAnalyzer ignore rule for the benign syncd
collectData: Failed to get port attr for VID ... RID ...: -<code>error anchored on the literal substring#syncd: :- collectData. rsyslog deduplicates repeated identical lines into a summary of the form:Because
message repeated N times: [sits between#syncd:and:- collectData, the rigid anchor does not match the collapsed line. LogAnalyzer then flags it and QoS SAI cases error on teardown (observed on Broadcom 7060x6 ft2/lt2 nightlies, e.g.str4-7060x6-512-4, image20251110.38— 14 QoS SAI teardown errors in a single nightly).Type of change
Back port request
Tracking issue/work item for backport/cherry-pick request: #24023
Failure type: day-one issue (test infrastructure — the collapsed-log form was never covered by the ignore rule)
Approach
What is the motivation for this PR?
Eliminate false-positive LogAnalyzer teardown failures on Broadcom 7060x6 nightlies. A previous fix generalized the error code (
-2->-\d+), but the rule still only matched the un-collapsed line, so rsyslog'smessage repeated N times: [ ... ]summary continued to trip LogAnalyzer and error the QoS SAI cases at teardown.How did you do it?
Replaced the rigid
#syncd: :- collectDataanchor with#syncd:.*collectDatainloganalyzer_common_ignore.txt, so both the direct and the rsyslog-collapsed forms are ignored. The rest of the pattern (VID/RID hex and-\d+error code) is unchanged, keeping the rule scoped to this specific benign error.How did you verify/test it?
Validated the new regex against the exact lines from the failing nightly: it matches both the direct line and the
message repeated N times: [ ... ]collapsed line, matches multi-asicsyncd0, and does not match unrelatedcollectDataerrors.Any platform specific information?
Broadcom 7060x6 (ft2/lt2 topologies). The SAI return code observed on this platform is
-8; the log volume triggers rsyslog message collapsing.Supported testbed topology if it's a new test case?
N/A — not a new test case.
Documentation
N/A — no documentation change required.
Signed-off-by: Sonic Build Admin sonicbld@microsoft.com