[action] [PR:25988] Removed admin_up checks from test_switch_host_status_control#1301
Merged
Merged
Conversation
### Description of PR
Summary:
Remove the admin_up checks from test_switch_host_status_control since admin_up is the config option and the test is calling the API directly.
Test test is calling the platform API to toggle the SWITCH-HOST power.
The config and admin status does not change.
### Type of change
- [X] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
- [ ] Skipped for non-supported platforms
- [ ] Test case improvement
### Back port request
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505
- [ ] 202511
- [ ] 202512
- [ ] 202605
### Approach
#### What is the motivation for this PR?
Fix the expected CLI state in the test
#### How did you do it?
Removed the admin state checks, as driven by the config
#### How did you verify/test it?
Ran the test on the BMC testbed
Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
#### Any platform specific information?
#### Supported testbed topology if it's a new test case?
### Documentation
Collaborator
Author
|
Original PR: sonic-net/sonic-mgmt#25988 |
Collaborator
Author
|
/azp run |
12 tasks
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Remove the admin_up checks from test_switch_host_status_control since admin_up is the config option and the test is calling the API directly.
Test test is calling the platform API to toggle the SWITCH-HOST power.
The config and admin status does not change.
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix the expected CLI state in the test
How did you do it?
Removed the admin state checks, as driven by the config
How did you verify/test it?
Ran the test on the BMC testbed
Signed-off-by: Sonic Build Admin sonicbld@microsoft.com
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation