[action] [PR:25769] Fix test_thermalctld_leak_status#1297
Merged
Conversation
### Description of PR Adds correct handling for "None" leak status returned by redis. Also fixes the flake8 error than prevent the verifications to pass Summary: Fixes sonic-net/sonic-mgmt#25760 ### Type of change - [X] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [X] Test case improvement ### Back port request - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [ ] 202511 - [ ] 202512 - [ ] 202605 ### Approach #### What is the motivation for this PR? Fix test_thermalctld_leak_status #### How did you do it? Treated the redis returned value "None" as string and checked for it, added the enum prefix "LeakSeverity." to the leak_severity expected values #### How did you verify/test it? Ran on the BMC testbed Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com> #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation
Collaborator
Author
|
Original PR: sonic-net/sonic-mgmt#25769 |
Collaborator
Author
|
/azp run |
12 tasks
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Adds correct handling for "None" leak status returned by redis.
Also fixes the flake8 error than prevent the verifications to pass
Summary:
Fixes sonic-net/sonic-mgmt#25760
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix test_thermalctld_leak_status
How did you do it?
Treated the redis returned value "None" as string and checked for it, added the enum prefix "LeakSeverity." to the leak_severity expected values
How did you verify/test it?
Ran on the BMC testbed
Signed-off-by: Sonic Build Admin sonicbld@microsoft.com
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation