[TH6-128] Increase announce routes networks for lt2-o256-u32d224 topo#1291
Merged
bingwang-ms merged 1 commit intoJul 7, 2026
Conversation
… (#24665) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) - This PR fixes _Announce routes_ task failure during add-topo for LT2 DUTs which has more T1 VMs. - For _lt2-o256-u32d224_ topo, DUT needs to have 224 T1 VMs, whereas the current code has support only for 110 T1 VMs. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [x] 202511 ### Approach #### What is the motivation for this PR? - To fix announce routes failure for _lt2-o256-u32d224_ topo DUTs, which needs more T1 networks. #### How did you do it? - 224 T1 VMs need at least 7 networks, modified the code to support that. #### How did you verify/test it? - Ran add-topo for _lt2-o256-u32d224_ and made sure it's working fine without any issues. #### Any platform specific information? LT2 #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> Signed-off-by: sanrajen <sanjai.rajendran@nokia.com> Signed-off-by: Anders Linn <anders@nexthop.ai>
Closed
12 tasks
Author
@microsoft-github-policy-service agree [company="Nexthop AI"] |
Author
|
@bingwang-ms I am not a maintainer on this repo. I signed the CLA, can you approve the workflow please? |
Merged
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Cherry-pick of sonic-net/sonic-mgmt#24665 to 202512, per @bingwang-ms's note that sonic-mgmt 202512 backports land in this repo. Original author: @sanjair-git.
Type of change
Approach
Cherry-picked sonic-net/sonic-mgmt#24665. It applied cleanly on 202512 — the existing 8-network hardcode (192.168-192.175.0.0/27) matches the source PR's base — so the result is the dynamic scheme it introduced:
num_extra = max(4, ceil(len(t1_vms) / 32))building192.(168+i).0.0/27, matching current master. Backward-compatible: any topo with <=128 T1 VMs yields the same blocks as before; it expands (7 blocks for the 224-T1 topo) only where more networks are needed.Verified the resulting
fib_lt2_routesmatches master's post-#24665 shape and that the module compiles; relying on 202512 CI for the functional run.