Skip to content

Update json tags and argument count for management interface address and arp cmds #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sreevanich16 merged 4 commits into from
May 26, 2026
Merged

Update json tags and argument count for management interface address and arp cmds #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
04203b1
Update show_paths.go
Sreevanich16 May 26, 2026
466e634
Update management_interface_address_cli.go
Sreevanich16 May 26, 2026
bf77e30
Update management_interface_address_cli_test.go
Sreevanich16 May 26, 2026
c58aa25
Update management_interface_address_cli_test.go
Sreevanich16 May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gnmi_server/management_interface_address_cli_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ func TestGetManagementInterfaceAddress(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), QueryTimeout*time.Second)
defer cancel()

expectedManagementInterface := `[{"Management IP address":"10.0.0.5/8","Management Network Default Gateway":"10.0.0.1"},{"Management IP address":"192.168.1.100/24","Management Network Default Gateway":"192.168.1.1"}]`
expectedManagementInterface := `[{"management_ip_address":"10.0.0.5/8","management_network_default_gateway":"10.0.0.1"},{"management_ip_address":"192.168.1.100/24","management_network_default_gateway":"192.168.1.1"}]`

tests := []struct {
desc string
Expand Down Expand Up @@ -96,7 +96,7 @@ func TestGetManagementInterfaceAddress(t *testing.T) {
elem: <name: "address" >
`,
wantRetCode: codes.OK,
wantRespVal: []byte(`[{"Management IP address":"192.168.1.100/24","Management Network Default Gateway":""}]`),
wantRespVal: []byte(`[{"management_ip_address":"192.168.1.100/24","management_network_default_gateway":""}]`),
valTest: true,
testInit: func() *gomonkey.Patches {
patches := gomonkey.NewPatches()
Expand Down
4 changes: 2 additions & 2 deletions show_client/management_interface_address_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ import (

// ManagementInterfaceAddress represents a single management interface address entry
type ManagementInterfaceAddress struct {
ManagementIPAddress string `json:"Management IP address"`
ManagementNetworkDefaultGateway string `json:"Management Network Default Gateway"`
ManagementIPAddress string `json:"management_ip_address"`
ManagementNetworkDefaultGateway string `json:"management_network_default_gateway"`
}

const (
Expand Down
2 changes: 1 addition & 1 deletion show_client/show_paths.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,7 +861,7 @@ func init() {
getARP,
"SHOW/arp/{ipaddress}[OPTIONS]: Show IP ARP table",
0,
2,
1,
nil,
showCmdOptionSonicCliIfaceMode,
showCmdOptionIface,
Expand Down
Loading