Conversation
0a9d91a to
834a06b
Compare
There was a problem hiding this comment.
Pull request overview
This PR extends runkperf’s data command suite to support ingesting Kubernetes Events and Secrets, while refactoring shared Kubernetes client/namespace helpers into contrib/cmd/runkperf/commands/data/client.go for reuse across data subcommands.
Changes:
- Add
data eventsubcommands to create/list/delete benchmark Event objects. - Add
data secretsubcommands to create/list/delete benchmark Secret objects. - Refactor existing data commands to use shared client + namespace helpers, and centralize random data generation utilities.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| contrib/cmd/runkperf/commands/root.go | Registers the new event and secret data subcommands. |
| contrib/cmd/runkperf/commands/data/events/event.go | Implements event set creation, listing, and deletion (with rate limiting options). |
| contrib/cmd/runkperf/commands/data/secrets/secret.go | Implements secret set creation, listing, and deletion (with rate limiting options). |
| contrib/cmd/runkperf/commands/data/daemonsets/daemonset.go | Refactors to use centralized client + namespace helpers from data. |
| contrib/cmd/runkperf/commands/data/configmaps/configmap.go | Refactors to use centralized helpers and shared random string generator. |
| contrib/cmd/runkperf/commands/data/client.go | Adds PrepareNamespace() and shared random data helpers (RandBytes, RandString). |
| .gitignore | Ignores .claude/ directory. |
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR extends runkperf data with new subcommands for generating and managing Kubernetes Event and Secret objects, while refactoring shared client/namespace helpers into the data package to reduce duplication across data-ingestion commands.
Changes:
- Add
data eventsubcommands (add/list/delete) for generating labeled Event sets. - Add
data secretsubcommands (add/list/delete) for generating labeled Secret sets. - Refactor shared helpers into
contrib/cmd/runkperf/commands/data/client.goand update existing configmap/daemonset commands to use them.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| contrib/cmd/runkperf/commands/root.go | Registers new data event and data secret subcommands. |
| contrib/cmd/runkperf/commands/data/secrets/secret.go | Implements secret set add/list/delete with batching + pagination. |
| contrib/cmd/runkperf/commands/data/events/event.go | Implements event set add/list/delete with batching + pagination. |
| contrib/cmd/runkperf/commands/data/daemonsets/daemonset.go | Switches to shared data client + namespace helper functions. |
| contrib/cmd/runkperf/commands/data/configmaps/configmap.go | Fixes label var name and switches to shared namespace/random helpers. |
| contrib/cmd/runkperf/commands/data/client.go | Adds PrepareNamespace and random data helpers used across subcommands. |
| .gitignore | Ignores .claude/ directory. |
60d6e23 to
62fdb8d
Compare
There was a problem hiding this comment.
Pull request overview
Adds new runkperf data subcommands for generating, listing, and deleting Kubernetes Event and Secret objects, while refactoring shared client/helpers into the data client utilities to reduce duplication across existing data commands.
Changes:
- Introduce
data eventanddata secretcommand groups withadd/list/delworkflows, including paging and configurable concurrency (--group-size). - Refactor shared helpers into
contrib/cmd/runkperf/commands/data/client.go(namespace preparation + random payload generators) and migrate existing commands to use them. - Register new subcommands and update ignore rules for local tooling.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| contrib/cmd/runkperf/commands/root.go | Registers the new events and secrets data subcommands under runkperf data. |
| contrib/cmd/runkperf/commands/data/events/event.go | Implements data event add/list/del with paging and parallelism controls. |
| contrib/cmd/runkperf/commands/data/secrets/secret.go | Implements data secret add/list/del with paging and parallelism controls. |
| contrib/cmd/runkperf/commands/data/daemonsets/daemonset.go | Switches to shared data client helpers (rate-limited client + PrepareNamespace). |
| contrib/cmd/runkperf/commands/data/configmaps/configmap.go | Switches to shared helpers (PrepareNamespace + RandString + shared AppLabel). |
| contrib/cmd/runkperf/commands/data/client.go | Adds PrepareNamespace, RandString/RandBytes, and AppLabel constant. |
| .gitignore | Ignores .claude/ directory. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
add/list/delfor event object creation / list / deletionlistanddelcommands uses paging (default to 300 items) to fetch data in trunksaddanddelcommand uses--group-sizeto control concurrent requests sent to API serveradd/list/delfor secret object creation / list / deletionRandString()andRandBytes()for payload generationPrepareNamespacefor creating namespace