Repository navigation
Make live Core HTTP benchmarks opt-in - #5371
Merged
Tomas Varon (tvaron3) merged 4 commits intoSep 29, 2026
Merged
Conversation
Remove the required dependency on the retired SDK-hosted httpbin service. Follow the explicit endpoint configuration approach in Azure/azure-sdk-for-cpp#7216 to unblock Core benchmark failures affecting #5334. Use AZURE_CORE_HTTPBIN_URL in the transport benchmarks and ureq example. Report unconfigured and macOS-skipped runs explicitly, and preserve errors for invalid configuration and failed requests. Replace the unpublished example helper's endpoint constant with validated configuration and tests, regenerate its API artifact, and document setup and execution limits in the Core README. Published APIs and recorded telemetry tests remain unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Larry Osterman (LarryOsterman)
approved these changes
Sep 28, 2026
Anton Kolesnyk (antkmsft)
approved these changes
Sep 28, 2026
Use AZSDKRUSTTEST_HTTPBIN_URL to identify the SDK and test-only purpose, matching the C++ SDK naming convention. Update the helper's environment lookup, diagnostics, and tests alongside benchmark/example messages and README commands. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Tomas Varon (tvaron3)
enabled auto-merge (squash)
September 28, 2026 21:49
Anton Kolesnyk (antkmsft)
approved these changes
Sep 28, 2026
Heath Stewart (heaths)
requested changes
Sep 28, 2026
Recognize the Rust test endpoint variable in the shared cSpell configuration to fix Analyze failures. Move live benchmark and example setup from the Core README to CONTRIBUTING.md, keeping contributor instructions out of the published crate documentation as requested in review. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
Rename the endpoint setting to AZURE_TEST_HTTPBIN_URL in the helper, tests, benchmark/example diagnostics, and contributor commands to follow the existing Azure SDK convention requested in review. Remove the spelling exception for the superseded Rust-specific prefix. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Heath Stewart (heaths)
approved these changes
Sep 29, 2026
Tomas Varon (tvaron3)
deleted the
tvaron3-replace-retired-httpbin-dependency
branch
September 29, 2026 00:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The SDK-hosted httpbin service at
azuresdkforcpp.azurewebsites.netwas intentionally retired. Core's four live HTTP transport benchmarks still require it, causing Linux and Windows CI failures, including those affecting #5334. This separate Core-only fix follows the explicit opt-in approach in Azure/azure-sdk-for-cpp#7216.azure_core_exampleshelper with validatedAZSDKRUSTTEST_HTTPBIN_URLconfiguration, add configuration tests, and regenerate its API artifact.core_ureq_clientto require the same configuration and allow an explicitly configured local HTTP service.No fallback public endpoint or automatic server provisioning is introduced. Offline benchmarks, published Core APIs, recorded telemetry tests, and native cursor code remain unchanged.