Skip to content

Sync eng/common directory with azure-sdk-tools for PR 17035 - #5314

Open
azure-sdk-automation[bot] wants to merge 2 commits into
mainfrom
sync-eng-common-raych1-migrate-restapi-verification-token-17035
Open

azure-sdk-automation[bot] wants to merge 2 commits into
mainfrom
sync-eng-common-raych1-migrate-restapi-verification-token-17035

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#17035 See eng/common workflow

Ray Chen (raych1) and others added 2 commits September 15, 2026 22:02
Fixes #16614

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 15, 2026 22:18
@azure-sdk-automation
azure-sdk-automation Bot requested a review from a team as a code owner September 15, 2026 22:18
@azure-sdk-automation azure-sdk-automation Bot added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Sep 15, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused template changes are consistent with existing authentication and pipeline-condition patterns.

Pull request overview

Updates shared pipeline templates to use the centralized GitHub authentication flow.

Changes:

  • Adds optional authentication-token handling to REST API spec verification.
  • Applies configurable conditions consistently to authentication and verification tasks.
File summaries
File Description
eng/common/pipelines/templates/steps/verify-restapi-spec-location.yml Adds automatic GitHub login, token override, and configurable conditions.
eng/common/pipelines/templates/steps/login-to-github.yml Adds configurable task execution conditions.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants