Improve PR failure annotations - #5239
Draft
Ashley Stanton-Nurse (analogrelay) wants to merge 4 commits into
Draft
Ashley Stanton-Nurse (analogrelay) wants to merge 4 commits into
Ashley Stanton-Nurse (analogrelay) wants to merge 4 commits into
Conversation
Parse Cargo JSON diagnostics into location-aware Azure DevOps issues while retaining full Rust output in task logs. Add structured annotations for failed tests and spelling errors, preserve JUnit publication, and validate the repository-local parsers in the analysis job. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 83c61f96-2dd3-4eb8-a4f2-ec7c35d1acbd
Introduce a deliberate type mismatch in azure_core so the draft PR pipeline can verify that Rust compiler diagnostics appear as GitHub annotations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 83c61f96-2dd3-4eb8-a4f2-ec7c35d1acbd
|
Azure Pipelines: Successfully started running 1 pipeline(s). 3 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Replace the intentional compiler failure with a misspelled comment and a failing azure_core unit test so the draft PR can validate both annotation paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 83c61f96-2dd3-4eb8-a4f2-ec7c35d1acbd
Member
Author
There was a problem hiding this comment.
This is a temporary test measure just to prove it's possible before I port the changes over to eng/common via the central tools repo. I'll revert this before merging and we'll get it if/when it lands there.
Remove the temporary spelling and unit-test failures now that both PR annotation paths have been verified. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 83c61f96-2dd3-4eb8-a4f2-ec7c35d1acbd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse Cargo JSON diagnostics into location-aware Azure DevOps issues so compiler and Clippy failures can flow into GitHub Check annotations with Rust’s full rendered error message.
Add structured annotations for failed tests and spelling errors, retain JUnit test publication, cap noisy commands at 50 annotations, and validate the repository-local parsers in the analysis job. No changes are made under
eng/common/.The compiler, spelling, and test annotation paths were verified with temporary failures that have now been removed.