Modify logic to ensure that the cloud_RoleInstance gets populated with the k8 pod name if specified#45884
Open
rads-1996 wants to merge 3 commits intoAzure:mainfrom
Open
Modify logic to ensure that the cloud_RoleInstance gets populated with the k8 pod name if specified#45884rads-1996 wants to merge 3 commits intoAzure:mainfrom
rads-1996 wants to merge 3 commits intoAzure:mainfrom
Conversation
…h the k8 pod name if specified
8185850 to
12cf11f
Compare
Member
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes cloud_RoleInstance resolution for Kubernetes/AKS by prioritizing the Kubernetes pod name when it is present, addressing inconsistent values caused by service.instance.id being set by resource detectors.
Changes:
- Update role instance resolution order to prefer
k8s.pod.nameoverservice.instance.id. - Expand unit tests to cover the new precedence and fallback behaviors (pod name → service instance id → hostname).
- Document the bug fix in the package changelog.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_utils.py | Changes _get_cloud_role_instance() precedence to use Kubernetes pod name first. |
| sdk/monitor/azure-monitor-opentelemetry-exporter/tests/test_utils.py | Updates/adds tests validating precedence and fallback behavior for role instance. |
| sdk/monitor/azure-monitor-opentelemetry-exporter/CHANGELOG.md | Adds an unreleased bug-fix entry describing the precedence change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes - #45532
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines