Move sampler argument logic to respective samplers#45849
Draft
rads-1996 wants to merge 18 commits intoAzure:mainfrom
Draft
Move sampler argument logic to respective samplers#45849rads-1996 wants to merge 18 commits intoAzure:mainfrom
rads-1996 wants to merge 18 commits intoAzure:mainfrom
Conversation
e94131a to
22ad132
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves OTEL_TRACES_SAMPLER_ARG parsing/defaulting logic into the sampler implementations themselves (ApplicationInsightsSampler and RateLimitedSampler), aligning behavior with the referenced issue and reducing reliance on higher-level configuration layers.
Changes:
- Updated
ApplicationInsightsSamplerto optionally readOTEL_TRACES_SAMPLER_ARGwhen no explicit ratio is provided, and to default (log) on invalid inputs rather than raising. - Updated
RateLimitedSamplerto optionally readOTEL_TRACES_SAMPLER_ARGwhen no explicit traces-per-second value is provided, and to default (log) on invalid inputs rather than raising. - Expanded unit tests to cover env-var and invalid-input behaviors for both samplers.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
sdk/monitor/azure-monitor-opentelemetry-exporter/tests/trace/test_sampling.py |
Updates tests for ApplicationInsightsSampler’s new env-var/defaulting behavior. |
sdk/monitor/azure-monitor-opentelemetry-exporter/tests/trace/test_rate_limited_sampling.py |
Adds tests for RateLimitedSampler’s new env-var/defaulting behavior and invalid inputs. |
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/trace/_sampling.py |
Implements env-var parsing and defaulting within ApplicationInsightsSampler. |
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/trace/_rate_limited_sampling.py |
Implements env-var parsing and defaulting within RateLimitedSampler. |
...onitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/trace/_sampling.py
Show resolved
Hide resolved
...onitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/trace/_sampling.py
Show resolved
Hide resolved
...lemetry-exporter/azure/monitor/opentelemetry/exporter/export/trace/_rate_limited_sampling.py
Show resolved
Hide resolved
...lemetry-exporter/azure/monitor/opentelemetry/exporter/export/trace/_rate_limited_sampling.py
Show resolved
Hide resolved
...onitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/trace/_sampling.py
Show resolved
Hide resolved
sdk/monitor/azure-monitor-opentelemetry-exporter/tests/trace/test_sampling.py
Show resolved
Hide resolved
sdk/monitor/azure-monitor-opentelemetry-exporter/tests/trace/test_rate_limited_sampling.py
Outdated
Show resolved
Hide resolved
22ad132 to
3cd96ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes - #32499
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines