[Az.CosmosDB] Add support for capabilities and disableLocalAuth updates in UpdateAzCosmosDBAccount#29290
Open
tiffanytsang wants to merge 4 commits intoAzure:mainfrom
Open
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Contributor
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support in Az.CosmosDB for updating Cosmos DB account Capabilities and the DisableLocalAuth property, and updates scenario tests accordingly.
Changes:
- Plumbs
DisableLocalAuththrough create/update cmdlets and result model. - Adds
-CapabilitiestoUpdate-AzCosmosDBAccountand maps string names to SDKCapabilityobjects. - Extends scenario tests to validate
DisableLocalAuthandCapabilitiesupdates.
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/CosmosDB/CosmosDB/Models/DatabaseAccount/PSDatabaseAccountGetResults.cs | Exposes DisableLocalAuth on the PS model and maps it from SDK results. |
| src/CosmosDB/CosmosDB/Helpers/Constants.cs | Adds help messages for DisableLocalAuth and Capabilities. |
| src/CosmosDB/CosmosDB/CosmosDBAccount/UpdateAzCosmosDBAccount.cs | Adds -Capabilities parameter and maps it into update parameters; applies DisableLocalAuth on update. |
| src/CosmosDB/CosmosDB/CosmosDBAccount/NewOrUpdateAzCosmosDBAccount.cs | Adds shared DisableLocalAuth parameter for create/update cmdlets. |
| src/CosmosDB/CosmosDB/CosmosDBAccount/NewAzCosmosDBAccount.cs | Sends DisableLocalAuth on account creation. |
| src/CosmosDB/CosmosDB.Test/ScenarioTests/AccountTests.ps1 | Updates scenario coverage for DisableLocalAuth and Capabilities. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Comment on lines
+53
to
+55
| [Parameter(Mandatory = false, HelpMessage = Constants.CapabilitiesHelpMessage)] | ||
| public string[] Capabilities { get; set; } | ||
|
|
There was a problem hiding this comment.
This PR introduces new user-facing behavior/parameters (-Capabilities updates on Update-AzCosmosDBAccount and -DisableLocalAuth exposure) but src/CosmosDB/CosmosDB/ChangeLog.md still has an empty “## Upcoming Release” section. Please add an entry describing these changes for the next release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.