-
Notifications
You must be signed in to change notification settings - Fork 640
FEAT [BREAKING]: Scorer evaluation refactor #1280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I made a PR into your branch; check it out :) |
Simplifying Scorer Evaluation
jsong468
commented
Dec 31, 2025
rlundeen2
reviewed
Jan 6, 2026
rlundeen2
reviewed
Jan 6, 2026
rlundeen2
approved these changes
Jan 6, 2026
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Because it is gigantic, but been worked on by both of us, I recommend the following next steps
- merge main
- Make sure .ipynb match .py
- Run integration tests and e2e tests make sure nothing is broken
- Merge PR
- Keep testing, do followup PR for issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the scorer evaluation framework to provide a simpler, more user-friendly API. Scorers now have direct evaluate_async() and get_scorer_metrics() methods, eliminating the need for manual evaluator instantiation.
Simplified API
New Scorer Evaluation Registry and scorer_metrics_io.py Module
RegistryUpdateBehavior.NEVER_UPDATE.get_all_objective_metricsorget_all_harm_metricsfor browsing/comparing scorer configurationsfind_metrics_by_hashfor looking up specific configurationsscorer_evaldirectories are cleaned up and separated into harm, objective, and refusalStandardized CSV Format
Added harm definitions/versions to HarmScorerMetrics and more details overall in ScorerMetrics
HarmScorerMetrics.HarmScorerMetricsincludes new harm-specific fields.ScorerMetricsbase class includes more details on the evaluation likenum_responsesandnum_scorer_trialsRemoved Components
Added evaluate_scorers script
Scorer Printer
Documentation
Testing
Breaking Changes
ScorerEvaluatorhas been changed significantly and some older methods do not exist.SelfAskLikertScorerparam change fromlikert_scale_pathtolikert_scaleTODO (future PRs)
trial_scoresattribute ofScorerMetrics