Regenerate Sql and AzureBlob with the corrected Purview parameter name - #227
Draft
daviburg wants to merge 1 commit into
Draft
Regenerate Sql and AzureBlob with the corrected Purview parameter name#227daviburg wants to merge 1 commit into
daviburg wants to merge 1 commit into
Conversation
The shared Purview query parameter carries a triple-c typo in its x-ms-summary (`Purview Acccount Name`) while its `name` field is spelled correctly. The generator derives the C# identifier from the summary, so `purviewAcccountName` reached the public API surface; the wire query key was always correct. AzureUX-BPM PR 16639935 hoists the existing correction out of its documentdb-only gate so it applies to every connector. This regenerates the two affected clients: 12 occurrences in SqlExtensions, 20 in AzureBlobExtensions. Identifier-only change - no request behaviour changes. Build: 0 errors, 0 warnings. Tests: 912 passed, 0 failed. Co-authored-by: Dobby <dobby@microsoft.com>
There was a problem hiding this comment.
Pull request overview
Regenerates the SQL Server and Azure Blob connector clients to correct the public C# parameter identifier for the Purview query parameter (fixing the historical purviewAcccountName typo to purviewAccountName) while preserving the wire query key (purviewAccountName).
Changes:
- Regenerated
SqlExtensions.csto rename the affected optional parameter and its XML doc entries. - Regenerated
AzureBlobExtensions.csto apply the same parameter rename across affected operations (plus additional regeneration drift as noted in the PR description). - Documented the breaking identifier rename in
CHANGELOG.md.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Azure.Connectors.Sdk/Generated/SqlExtensions.cs | Regenerated output correcting purviewAcccountName → purviewAccountName in method signatures, docs, and query-param construction. |
| src/Azure.Connectors.Sdk/Generated/AzureBlobExtensions.cs | Regenerated output correcting purviewAcccountName → purviewAccountName across Azure Blob operations (with additional generator drift). |
| CHANGELOG.md | Adds a Breaking Changes entry describing the parameter identifier correction and impact on named-argument callers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Regenerates
SqlandAzureBlobfrom AzureUX-BPM PR 16639935, which corrects the Purview parameter identifier on the public API surface.The shared Purview query parameter declares
"name": "purviewAccountName"correctly but carries"x-ms-summary": "Purview Acccount Name"— triple c. The generator derives the C# parameter identifier fromx-ms-summaryrather than fromname, so the typo became part of the shipped API while the wire query key was always correct. The generator already had this correction but gated it behinddocumentdb; the misspelling lives in a$ref-shared global parameter, so every other importer kept emitting it.This is an identifier-only change. No request behaviour changes. Callers passing the parameter positionally are unaffected; callers using a named argument must rename it.
Changes
SqlExtensions.csAzureBlobExtensions.csCHANGELOG.mdrecords the rename under Breaking Changes.Overlap with #226 — read before merging
AzureBlobExtensions.csis also modified by #226, the full-catalogue regeneration. That is why its diff here is 209 lines rather than the 40 the typo fix alone produces: 40 lines are the Purview correction and 169 are drift that #226 already carries.SqlExtensions.csdoes not overlap — #226 does not touch it — which is why its diff is exactly the 24 lines of the fix.Recommended order:
AzureBlobExtensions.csthen reduces to the ~40 Purview lines and the duplication disappears.Merging this before #226 also works, but then #226 must be regenerated against the updated generator or it will silently reintroduce the typo into
AzureBlobExtensions.cs.Both clients are regenerated together deliberately: correcting only
Sqlwould leaveAzureBlobinconsistent for the same shared parameter.Testing
Unit tests added/updated
All existing tests pass (
dotnet test)Manual testing (describe below if applicable)
dotnet build: 0 errors, 0 warnings.912 tests pass, 0 failures.
Generated from the BPM branch at commit
900f4c28e0with--directClient --connectors=sql,azureblob,documentdbagainst the pinned 1596-entry ARM cache.documentdbwas generated alongside to confirm it is unaffected — it was already covered by the old gate and regenerates byte-identical.Verified zero residual
Acccountoccurrences across all three clients.No unit tests added: this PR contains only generated output. The generator behaviour is covered by two new tests in the paired BPM PR, one of which was explicitly verified non-vacuous.
Checklist
src/**/Generated/(see CONTRIBUTING.md)release_notes.mdupdated (if shipping a new version, clear previous version notes)eng/build/Version.props(if shipping a new version)The
Generated/checkbox is intentionally left unchecked: this is a generator-driven regeneration, the sanctioned way those files change. No file was hand-edited.Depends on AzureUX-BPM PR 16639935 merging first.
Authored with Dobby agent.