Skip to content

Regenerate Sql and AzureBlob with the corrected Purview parameter name - #227

Draft
daviburg wants to merge 1 commit into
mainfrom
fix/regen-sql-azureblob-purview-summary
Draft

Regenerate Sql and AzureBlob with the corrected Purview parameter name#227
daviburg wants to merge 1 commit into
mainfrom
fix/regen-sql-azureblob-purview-summary

Conversation

@daviburg

Copy link
Copy Markdown
Member

Description

Regenerates Sql and AzureBlob from AzureUX-BPM PR 16639935, which corrects the Purview parameter identifier on the public API surface.

The shared Purview query parameter declares "name": "purviewAccountName" correctly but carries "x-ms-summary": "Purview Acccount Name" — triple c. The generator derives the C# parameter identifier from x-ms-summary rather than from name, so the typo became part of the shipped API while the wire query key was always correct. The generator already had this correction but gated it behind documentdb; the misspelling lives in a $ref-shared global parameter, so every other importer kept emitting it.

This is an identifier-only change. No request behaviour changes. Callers passing the parameter positionally are unaffected; callers using a named argument must rename it.

Changes

Client Purview occurrences corrected Total changed lines
SqlExtensions.cs 12 24
AzureBlobExtensions.cs 20 209

CHANGELOG.md records the rename under Breaking Changes.

Overlap with #226 — read before merging

AzureBlobExtensions.cs is also modified by #226, the full-catalogue regeneration. That is why its diff here is 209 lines rather than the 40 the typo fix alone produces: 40 lines are the Purview correction and 169 are drift that #226 already carries. SqlExtensions.cs does not overlap — #226 does not touch it — which is why its diff is exactly the 24 lines of the fix.

Recommended order:

  1. Merge AzureUX-BPM 16639935.
  2. Merge Regenerate all connector clients from the type-identity generator fix #226.
  3. Rebase this PR. AzureBlobExtensions.cs then reduces to the ~40 Purview lines and the duplication disappears.

Merging this before #226 also works, but then #226 must be regenerated against the updated generator or it will silently reintroduce the typo into AzureBlobExtensions.cs.

Both clients are regenerated together deliberately: correcting only Sql would leave AzureBlob inconsistent for the same shared parameter.

Testing

  • Unit tests added/updated

  • All existing tests pass (dotnet test)

  • Manual testing (describe below if applicable)

  • dotnet build: 0 errors, 0 warnings.

  • 912 tests pass, 0 failures.

  • Generated from the BPM branch at commit 900f4c28e0 with --directClient --connectors=sql,azureblob,documentdb against the pinned 1596-entry ARM cache. documentdb was generated alongside to confirm it is unaffected — it was already covered by the old gate and regenerates byte-identical.

  • Verified zero residual Acccount occurrences across all three clients.

No unit tests added: this PR contains only generated output. The generator behaviour is covered by two new tests in the paired BPM PR, one of which was explicitly verified non-vacuous.

Checklist

  • Code follows the project's coding conventions
  • No modifications to files under src/**/Generated/ (see CONTRIBUTING.md)
  • Documentation updated (if behavior changed)
  • CHANGELOG.md updated (if user-facing change)
  • release_notes.md updated (if shipping a new version, clear previous version notes)
  • Version updated in eng/build/Version.props (if shipping a new version)

The Generated/ checkbox is intentionally left unchecked: this is a generator-driven regeneration, the sanctioned way those files change. No file was hand-edited.

Depends on AzureUX-BPM PR 16639935 merging first.

Authored with Dobby agent.

The shared Purview query parameter carries a triple-c typo in its x-ms-summary
(`Purview Acccount Name`) while its `name` field is spelled correctly. The
generator derives the C# identifier from the summary, so `purviewAcccountName`
reached the public API surface; the wire query key was always correct.

AzureUX-BPM PR 16639935 hoists the existing correction out of its documentdb-only
gate so it applies to every connector. This regenerates the two affected clients:
12 occurrences in SqlExtensions, 20 in AzureBlobExtensions.

Identifier-only change - no request behaviour changes.

Build: 0 errors, 0 warnings. Tests: 912 passed, 0 failed.

Co-authored-by: Dobby <dobby@microsoft.com>
Copilot AI review requested due to automatic review settings July 31, 2026 03:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Regenerates the SQL Server and Azure Blob connector clients to correct the public C# parameter identifier for the Purview query parameter (fixing the historical purviewAcccountName typo to purviewAccountName) while preserving the wire query key (purviewAccountName).

Changes:

  • Regenerated SqlExtensions.cs to rename the affected optional parameter and its XML doc entries.
  • Regenerated AzureBlobExtensions.cs to apply the same parameter rename across affected operations (plus additional regeneration drift as noted in the PR description).
  • Documented the breaking identifier rename in CHANGELOG.md.

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

File Description
src/Azure.Connectors.Sdk/Generated/SqlExtensions.cs Regenerated output correcting purviewAcccountNamepurviewAccountName in method signatures, docs, and query-param construction.
src/Azure.Connectors.Sdk/Generated/AzureBlobExtensions.cs Regenerated output correcting purviewAcccountNamepurviewAccountName across Azure Blob operations (with additional generator drift).
CHANGELOG.md Adds a Breaking Changes entry describing the parameter identifier correction and impact on named-argument callers.

@daviburg daviburg self-assigned this Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants