Skip to content

Merge release/v1 to main 06/19#34

Merged
linglingye001 merged 3 commits intomainfrom
release/v1
Jun 19, 2025
Merged

Merge release/v1 to main 06/19#34
linglingye001 merged 3 commits intomainfrom
release/v1

Conversation

@linglingye001
Copy link
Member

No description provided.

@linglingye001 linglingye001 requested review from Copilot June 19, 2025 07:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request merges the release/v1 branch into main and updates the Azure App Configuration dependency from a beta version to the stable v1.0.0 release while also removing the local replace directives from various go.mod files. It also updates the version constant in the library and adds a nil-check for the refresh callback, and enriches the documentation with "Getting Started" quickstart links.

Reviewed Changes

Copilot reviewed 8 out of 24 changed files in this pull request and generated no comments.

Show a summary per file
File Description
example/gin_web_app/gin-example/go.mod Updated dependency version and removed local replace directive.
example/gin_web_app/gin-example-refresh/go.mod Updated dependency version and removed local replace directive.
example/console_app/console_example_refresh/go.mod Updated dependency version and removed local replace directive.
example/console_app/console_example/go.mod Updated dependency version and removed local replace directive.
azureappconfiguration/version.go Updated module version from a beta release to v1.0.0.
azureappconfiguration/azureappconfiguration.go Added nil-check for the refresh callback in OnRefreshSuccess.
azureappconfiguration/README.md Added enhanced “Getting Started” documentation with quickstarts.
README.md Added enhanced “Getting Started” documentation with quickstarts.
Comments suppressed due to low confidence (5)

example/gin_web_app/gin-example/go.mod:5

  • The removal of the replace directive may affect local dependency resolution. Confirm that this change is intentional and that developers are aware of the impact on local workflows.
require (

example/gin_web_app/gin-example-refresh/go.mod:42

  • The removal of the replace directive might alter module resolution for local development. Verify that the change aligns with the desired dependency management strategy.
	google.golang.org/protobuf v1.34.1 // indirect

example/console_app/console_example_refresh/go.mod:15

  • Removing the replace directive could affect local builds; please ensure that developers have an alternative mechanism for dependency resolution during development.
	golang.org/x/sync v0.13.0 // indirect

example/console_app/console_example/go.mod:17

  • The elimination of the local replace directive should be double-checked to ensure that dependency paths for local testing are correctly handled.
)

azureappconfiguration/azureappconfiguration.go:261

  • Since the function now silently returns when a nil callback is passed, consider updating the function’s documentation to clearly state that a nil callback will result in no operation to avoid confusion.
	if callback == nil {

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@linglingye001 linglingye001 merged commit 399e08e into main Jun 19, 2025
25 checks passed
@linglingye001 linglingye001 deleted the release/v1 branch June 19, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants