Merged
Conversation
| // - callback: A function with no parameters that will be called after a successful refresh | ||
| func (azappcfg *AzureAppConfiguration) OnRefreshSuccess(callback func()) { | ||
| if callback == nil { | ||
| log.Println("callback cannot be nil") |
| if callback != nil { | ||
| callback() | ||
| } | ||
| callback() |
Member
There was a problem hiding this comment.
This check is still necessary, don't remove it, check nil before using always right
Member
Author
There was a problem hiding this comment.
Are you saying that the callback can be changed during runtime?
Member
There was a problem hiding this comment.
At least in .net, using reflection can mutate any object at runtime (via reflection), Go also support reflection, not sure it's also feasible for Go or not, but nil check before use should always be right.
RichardChen820
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.