Skip to content

feat: enable Explore in all Grafanas#266

Merged
janboll merged 1 commit into
Azure:mainfrom
mmazur:bmamazur/grafana-viewers-can-edit-default
Jul 9, 2026
Merged

feat: enable Explore in all Grafanas#266
janboll merged 1 commit into
Azure:mainfrom
mmazur:bmamazur/grafana-viewers-can-edit-default

Conversation

@mmazur

@mmazur mmazur commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

https://redhat.atlassian.net/browse/AROSLSRE-1399

Why

ARO HCP wants Grafana Viewer-role users to access Explore without granting persistent Editor permissions. Azure Managed Grafana supports this through grafanaConfigurations.users.viewersCanEdit.

What

Validation

[vault@csb claude/pr-5933 (pr-5933)]$ az rest --method GET     --url "https://management.azure.com/subscriptions/1d3378d3-5a3f-4712-85a1-2485495dfc4b/resourceGroups/global/providers/Microsoft.Dashboard/grafana/mmazurtesting?api-version=2025-08-01"     --query "properties.grafanaConfigurations.users" -o json
[vault@csb claude/pr-5933 (pr-5933)]$ OVERRIDE_CONFIG_FILE=/tmp/grafana-override.yaml make pipeline/Grafana
make local-run WHAT="--service-group Microsoft.Azure.ARO.HCP.Grafana"
make[1]: Entering directory '/home/vault/work/claude/pr-5933'
(…)
make[1]: Leaving directory '/home/vault/work/claude/pr-5933'
[vault@csb claude/pr-5933 (pr-5933)]$ az rest --method GET     --url "https://management.azure.com/subscriptions/1d3378d3-5a3f-4712-85a1-2485495dfc4b/resourceGroups/global/providers/Microsoft.Dashboard/grafana/mmazurtesting?api-version=2025-08-01"     --query "properties.grafanaConfigurations.users" -o json
{
  "viewersCanEdit": true
}
Screenshot_20260708_160251-1

@mmazur mmazur force-pushed the bmamazur/grafana-viewers-can-edit-default branch from 4427734 to f2c5e65 Compare July 8, 2026 09:31
@mmazur mmazur changed the title feat: configure Grafana viewers can edit fix: enable Grafana viewers can edit Jul 8, 2026
@mmazur mmazur changed the title fix: enable Grafana viewers can edit feat: enable Explore in all Grafanas Jul 8, 2026
@mmazur mmazur force-pushed the bmamazur/grafana-viewers-can-edit-default branch from f2c5e65 to 685c880 Compare July 8, 2026 09:31
@mmazur mmazur marked this pull request as ready for review July 8, 2026 16:13
Copilot AI review requested due to automatic review settings July 8, 2026 16:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables Grafana “Explore” access for Viewer-role users in Azure Managed Grafana by ensuring the Azure resource configuration sets grafanaConfigurations.users.viewersCanEdit to true during grafanactl manage reconcile, aligning with the stated ARO HCP requirement.

Changes:

  • Adds azcore/to usage to set a *bool value conveniently.
  • Sets properties.grafanaConfigurations.users.viewersCanEdit = true on every create/update performed by grafanactl manage reconcile.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@mmazur mmazur force-pushed the bmamazur/grafana-viewers-can-edit-default branch from 685c880 to 2b073cc Compare July 9, 2026 08:56
@janboll janboll enabled auto-merge (squash) July 9, 2026 09:00
@janboll janboll merged commit c3198b5 into Azure:main Jul 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants