Skip to content

feat(pipelines): add IstioUpgrade step schema definition #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
trevorwilliams2025 wants to merge 2 commits into
base: main
Choose a base branch
from
+45 −3
Draft

feat(pipelines): add IstioUpgrade step schema definition #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93def4c
feat(pipelines): add IstioUpgrade step schema definition
trevorwilliams2025 Jul 8, 2026
8cf8b42
feat(pipelines): use Value type for aksCluster and drop dryRun from I…
trevorwilliams2025 Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pipelines/types/istio.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,11 @@ const StepActionIstioUpgrade = "IstioUpgrade"

type IstioUpgradeStep struct {
StepMeta `json:",inline"`
AKSCluster string `json:"aksCluster"`
DryRun bool `json:"dryRun,omitempty"`
AKSCluster Value `json:"aksCluster"`
}

func (s *IstioUpgradeStep) Description() string {
return fmt.Sprintf("Step %s\n Kind: %s\n AKSCluster: %s\n DryRun: %v\n", s.Name, s.Action, s.AKSCluster, s.DryRun)
return fmt.Sprintf("Step %s\n Kind: %s\n AKSCluster: %s\n", s.Name, s.Action, s.AKSCluster.String())
}

func (s *IstioUpgradeStep) RequiredInputs() []StepDependency {
Expand Down
43 changes: 43 additions & 0 deletions pipelines/types/pipeline.schema.v1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,6 +820,33 @@
}
]
},
"istioUpgradeStep": {
"unevaluatedProperties": false,
"allOf": [
{
"$ref": "#/definitions/stepMeta"
},
{
"properties": {
"action": {
"const": "IstioUpgrade"
},
"aksCluster": {
"$ref": "#/definitions/value"
},
"timeout": {
"$ref": "#/definitions/durationString"
},
"shellIdentity": {
"$ref": "#/definitions/value"
}
},
"required": [
"aksCluster"
]
}
]
},
"helmStep": {
"unevaluatedProperties": false,
"allOf": [
Expand Down Expand Up @@ -2073,6 +2100,22 @@
"then": {
"$ref": "#/definitions/grafanaDatasourcesStep"
}
},
{
"if": {
"type": "object",
"properties": {
"action": {
"const": "IstioUpgrade"
}
},
"required": [
"action"
]
},
"then": {
"$ref": "#/definitions/istioUpgradeStep"
}
}
],
"required": [
Expand Down