Istio phase support#264
Closed
trevorwilliams2025 wants to merge 2 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Phase selector to the IstioUpgradeStep type so pipelines can optionally split an Istio canary upgrade into discrete “install” vs “upgrade” steps, and surfaces that phase in the step’s Description() output for pipeline log visibility.
Changes:
- Added
Phasefield toIstioUpgradeStep(omitempty) with inline documentation describing expected values. - Updated
IstioUpgradeStep.Description()to print the selected phase.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
14 tasks
trevorwilliams2025
force-pushed
the
istio-phase-support
branch
from
83cd620 to
dd32d22
Compare
trevorwilliams2025
force-pushed
the
istio-phase-support
branch
from
dd32d22 to
afe0652
Compare
Comment on lines
+840
to
+846
| "phase": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "install", | ||
| "upgrade" | ||
| ] | ||
| } |
Comment on lines
+25
to
+28
| // "install" installs the new control plane alongside the existing one | ||
| // and stops before workload migration. "upgrade" migrates workloads and | ||
| // completes the canary. Empty runs the full lifecycle in one step. | ||
| Phase string `json:"phase,omitempty"` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phasefield toIstioUpgradeStepenabling the ability to split Istio upgrades into discrete steps withdependsOnchaininginstallinstalls the new control plane alongside the existing one and stops before workload migrationupgrademigrates workloads and completes the canaryPhasefield allows splitting it into separate pipeline steps with other actions (e.g. Helm config) in betweenPhaseinDescription()output for pipeline log visibilityContext
Without the phase field change, the
IstioUpgradeStepwould run the entire upgrade lifecycle in a single step. WithPhase,we can insert a Helm config step between control plane installation and workload migration —
matching the
istio-canary → istio-config → istio-rolloutpattern insvc-pipeline.yamlin afuture release.