Sudobrendan/unrevert 5754#6026
Draft
SudoBrendan wants to merge 3 commits into
Draft
Conversation
Restore alert, recording rule, and lane config files to their pre-revert state (before PR Azure#5754). Content is verbatim from commit 167ca21. Follow-up commits fix path prefixes, add severityCeiling, wire into deployment infrastructure, and address review feedback. Original work: PR Azure#5527 (SudoBrendan)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SudoBrendan The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Skipping CI for Draft Pull Request. |
- Rename UJ prefix to userJourney (camelCase) per ADR naming convention - Rename files from UJ* to UserJourney* for consistency - Downgrade all alert severities to warning for initial rollout - Add severityCeiling parameter to rp-hcp-rules.bicep - Wire rpHcpAlerts module into monitoring.bicep - Add run-rp-hcps build target to prometheus-rules Makefile - Fix alerts-rp-hcps.yaml path prefix to match main conventions - Rename CID to OCM Cluster ID in descriptions - Separate Management Cluster and Namespace into distinct lines - Add Environment and Region to descriptions (external labels) - Change summary format to [HCPKASAvailableBurn] with namespace - Add resource_id label to recording rule aggregation chains - Update all test expectations to match Co-Authored-By: Simon Wiencki <swiencki@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Generated from `make alerts recording-rules` in observability/. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
SudoBrendan
force-pushed
the
sudobrendan/unrevert-5754
branch
from
3fecde1 to
237d396
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Testing
Testing is required for feature completion and tests should be part of the pull
request along with the feature changes.
Describe the testing provided. If you did not add tests, provide a clear
justification.
Special notes for your reviewer
PR Checklist
If E2E tests are included:
demonstrate that the test is able to detect a defect/error and fail with
proper error message and logs which communicates nature of the problem.