fix(mgmt-agent): correctly place podwatcher to always run even if ksm is enabled/disabled

[bennerv]

What

Always run the podwatcher controller.

Why

Was incorrectly nested within the KSM image property being set or not.

Testing

Testing is required for feature completion and tests should be part of the pull
request along with the feature changes.

Describe the testing provided. If you did not add tests, provide a clear
justification.

• Unit tests
• Integration tests
• E2E tests

Special notes for your reviewer

PR Checklist

• PR is scoped to a single task (no mixed concerns)
• Title follows Conventional Commits format
• Summary explains the "Why" behind the change
• Linked to relevant ticket/issue
• Screenshots included (if graph/UI/metrics changes)
• Self-reviewed the diff
• CI/CD checks are passing (ignore Tide)
• Draft PR used for WIP (if applicable)
• Commit history is clean (rebased/squashed)
• Tricky code blocks are commented
• Specific reviewers tagged
• All comment threads resolved before merge

If E2E tests are included:

• E2E tests follow Principles of Good E2E Test Case Design
• If new E2E use case is covered (via a new test or new check/verifier),
  demonstrate that the test is able to detect a defect/error and fail with
  proper error message and logs which communicates nature of the problem.

[Copilot]

Pull request overview

This PR fixes mgmt-agent controller wiring so the PodWatcher is always created and started under leader election, regardless of whether the KSM image option is set.

Changes:

• Instantiate clusterWideKubeInformers and podWatcher unconditionally (outside the KSMImage conditional).
• Keep KSM controller/informers conditional on KSMImage, while ensuring PodWatcher always runs.

[stevekuznetsov]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bennerv, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [bennerv,stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 2776c19 and 2 for PR HEAD cbec9ef in total

[openshift-ci]

@bennerv: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/periodic-healthcheck-images	cbec9ef	link	true	/test periodic-healthcheck-images
ci/prow/test-unit	cbec9ef	link	true	/test test-unit
ci/prow/lint	cbec9ef	link	true	/test lint
ci/prow/integration	cbec9ef	link	true	/test integration
ci/prow/config-change-detection	cbec9ef	link	true	/test config-change-detection
ci/prow/image-updater-images	cbec9ef	link	true	/test image-updater-images
ci/prow/e2e-parallel	cbec9ef	link	true	/test e2e-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.