Skip to content

feat(frontend): Temporarily(?) include ARO Classic operations#6016

Open
mbarnes wants to merge 1 commit into
Azure:mainfrom
mbarnes:mbarnes/split-operations-plan-b
Open

feat(frontend): Temporarily(?) include ARO Classic operations#6016
mbarnes wants to merge 1 commit into
Azure:mainfrom
mbarnes:mbarnes/split-operations-plan-b

Conversation

@mbarnes

@mbarnes mbarnes commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

ARO-6602 - Strategy for ARO Operations API Between HCP and Classic

What

ARO-HCP will respond with both services' operations until we have approval to use the Split Operations ARM feature.

Why

This is Plan B of our strategy of implementing an operations endpoint that includes both ARO Classic and HCP operations.

Our preference is to use the Split Operations ARM feature, however on-boarding that feature requires our Azure namespace be whitelisted, and the Microsoft team responsible for doing so has paused adding any new namespaces since March on account of some issue on their end.

Current estimated TTR of said issue is, they claim, end of July, but we're too close to our own deadline to risk waiting.

Testing

This is additional static content and doesn't warrant new tests. I did adjust the unit test for operations to compensate for ARO Classic's non-conformance. I also did a manual comparison of ARO Classic's current operations output to ensure an exact match.

Special notes for your reviewer

PR Checklist

  • PR is scoped to a single task (no mixed concerns)
  • Title follows Conventional Commits format
  • Summary explains the "Why" behind the change
  • Linked to relevant ticket/issue
  • Screenshots included (if graph/UI/metrics changes)
  • Self-reviewed the diff
  • CI/CD checks are passing (ignore Tide)
  • Draft PR used for WIP (if applicable)
  • Commit history is clean (rebased/squashed)
  • Tricky code blocks are commented
  • Specific reviewers tagged
  • All comment threads resolved before merge

If E2E tests are included:

  • E2E tests follow Principles of Good E2E Test Case Design
  • If new E2E use case is covered (via a new test or new check/verifier),
    demonstrate that the test is able to detect a defect/error and fail with
    proper error message and logs which communicates nature of the problem.

ARO-HCP will respond with both services' operations until we have
approval to use the Split Operations ARM feature.
Copilot AI review requested due to automatic review settings July 10, 2026 15:10
@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbarnes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the frontend ARM .../providers/Microsoft.RedHatOpenShift/operations endpoint to temporarily return a combined operations list containing both ARO-HCP and ARO Classic operations, as a workaround until the ARM Split Operations feature can be enabled.

Changes:

  • Adds a static AvailableClassicOperations list (copied from ARO Classic) alongside the existing ARO-HCP AvailableOperations.
  • Updates ArmOperationsList to include both ARO-HCP and ARO Classic operations in the paged response.
  • Temporarily relaxes the operations unit test to tolerate ARO Classic’s missing display.description fields.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
frontend/pkg/frontend/routes.go Adds AvailableClassicOperations and documents why these are included and non-conformant.
frontend/pkg/frontend/frontend.go Appends classic operations to the operations list response.
frontend/pkg/frontend/frontend_test.go Adjusts the operations list test to accommodate ARO Classic operation payload differences.

Comment thread frontend/pkg/frontend/frontend_test.go
Comment thread frontend/pkg/frontend/routes.go
@mbarnes

mbarnes commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

/retest

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown

@mbarnes: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-parallel 0e52a0d link true /test e2e-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants