feat(frontend): Temporarily(?) include ARO Classic operations#6016
feat(frontend): Temporarily(?) include ARO Classic operations#6016mbarnes wants to merge 1 commit into
Conversation
ARO-HCP will respond with both services' operations until we have approval to use the Split Operations ARM feature.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbarnes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR updates the frontend ARM .../providers/Microsoft.RedHatOpenShift/operations endpoint to temporarily return a combined operations list containing both ARO-HCP and ARO Classic operations, as a workaround until the ARM Split Operations feature can be enabled.
Changes:
- Adds a static
AvailableClassicOperationslist (copied from ARO Classic) alongside the existing ARO-HCPAvailableOperations. - Updates
ArmOperationsListto include both ARO-HCP and ARO Classic operations in the paged response. - Temporarily relaxes the operations unit test to tolerate ARO Classic’s missing
display.descriptionfields.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/pkg/frontend/routes.go | Adds AvailableClassicOperations and documents why these are included and non-conformant. |
| frontend/pkg/frontend/frontend.go | Appends classic operations to the operations list response. |
| frontend/pkg/frontend/frontend_test.go | Adjusts the operations list test to accommodate ARO Classic operation payload differences. |
|
/retest |
|
@mbarnes: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ARO-6602 - Strategy for ARO Operations API Between HCP and Classic
What
ARO-HCP will respond with both services' operations until we have approval to use the Split Operations ARM feature.
Why
This is Plan B of our strategy of implementing an operations endpoint that includes both ARO Classic and HCP operations.
Our preference is to use the Split Operations ARM feature, however on-boarding that feature requires our Azure namespace be whitelisted, and the Microsoft team responsible for doing so has paused adding any new namespaces since March on account of some issue on their end.
Current estimated TTR of said issue is, they claim, end of July, but we're too close to our own deadline to risk waiting.
Testing
This is additional static content and doesn't warrant new tests. I did adjust the unit test for operations to compensate for ARO Classic's non-conformance. I also did a manual comparison of ARO Classic's current operations output to ensure an exact match.
Special notes for your reviewer
PR Checklist
If E2E tests are included:
demonstrate that the test is able to detect a defect/error and fail with
proper error message and logs which communicates nature of the problem.