fix: normalize kubelet fix DS image to pinned Azure Linux runtime#6009
fix: normalize kubelet fix DS image to pinned Azure Linux runtime#6009hlipsig wants to merge 4 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hlipsig The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test all |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the mgmt-fixes kubelet-parameters DaemonSet to stop using the unpinned alpine image and instead use the centrally-managed, digest-pinned aksCommandRuntime image (Azure Linux runtime), aligning the fix workload with the project’s Azure Linux 3 requirement.
Changes:
- Adds an image value (derived from
aksCommandRuntime) to the kubelet DS values template. - Switches the DaemonSet container image from
alpineto the configured pinned image. - Updates the Helm template golden fixture output to reflect the new image.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mgmt-fixes/kubelet-ds.values.yaml | Adds a chart value for the pinned runtime image used by the kubelet fix DaemonSet. |
| mgmt-fixes/deploy/kubelet-ds/templates/ds-kubelet-parameters.yaml | Uses the values-provided pinned runtime image instead of alpine. |
| dev-infrastructure/zz_fixture_TestHelmTemplate_dev_westus3_mgmt_1_mgmt_fixes.yaml | Updates rendered fixture to match the new DaemonSet image. |
| fi | ||
| sleep infinity | ||
| image: alpine | ||
| image: "{{ .Values.image }}" |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
@hlipsig: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
(https://redhat.atlassian.net/browse/ARO-28262)
What
Adjusts the Daemonset to use the Azure Linux 3 os image.
Why
Azure Linux 3 is a requirement for our project.
Testing
Testing is required for feature completion and tests should be part of the pull
request along with the feature changes.
Describe the testing provided. If you did not add tests, provide a clear
justification.
Special notes for your reviewer
PR Checklist
If E2E tests are included:
demonstrate that the test is able to detect a defect/error and fail with
proper error message and logs which communicates nature of the problem.