Skip to content

fix: normalize kubelet fix DS image to pinned Azure Linux runtime#6009

Open
hlipsig wants to merge 4 commits into
Azure:mainfrom
hlipsig:dockerfile-image-normalization
Open

fix: normalize kubelet fix DS image to pinned Azure Linux runtime#6009
hlipsig wants to merge 4 commits into
Azure:mainfrom
hlipsig:dockerfile-image-normalization

Conversation

@hlipsig

@hlipsig hlipsig commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

(https://redhat.atlassian.net/browse/ARO-28262)

What

Adjusts the Daemonset to use the Azure Linux 3 os image.

Why

Azure Linux 3 is a requirement for our project.

Testing

Testing is required for feature completion and tests should be part of the pull
request along with the feature changes.

Describe the testing provided. If you did not add tests, provide a clear
justification.

Special notes for your reviewer

PR Checklist

  • PR is scoped to a single task (no mixed concerns)
  • Title follows Conventional Commits format
  • Summary explains the "Why" behind the change
  • Linked to relevant ticket/issue
  • Screenshots included (if graph/UI/metrics changes)
  • Self-reviewed the diff
  • CI/CD checks are passing (ignore Tide)
  • Draft PR used for WIP (if applicable)
  • Commit history is clean (rebased/squashed)
  • Tricky code blocks are commented
  • Specific reviewers tagged
  • All comment threads resolved before merge

If E2E tests are included:

  • E2E tests follow Principles of Good E2E Test Case Design
  • If new E2E use case is covered (via a new test or new check/verifier),
    demonstrate that the test is able to detect a defect/error and fail with
    proper error message and logs which communicates nature of the problem.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hlipsig
Once this PR has been reviewed and has the lgtm label, please assign geoberle for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hlipsig

hlipsig commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

/test all

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@hlipsig hlipsig marked this pull request as ready for review July 10, 2026 20:23
Copilot AI review requested due to automatic review settings July 10, 2026 20:23
@openshift-ci openshift-ci Bot requested review from janboll and weherdh July 10, 2026 20:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the mgmt-fixes kubelet-parameters DaemonSet to stop using the unpinned alpine image and instead use the centrally-managed, digest-pinned aksCommandRuntime image (Azure Linux runtime), aligning the fix workload with the project’s Azure Linux 3 requirement.

Changes:

  • Adds an image value (derived from aksCommandRuntime) to the kubelet DS values template.
  • Switches the DaemonSet container image from alpine to the configured pinned image.
  • Updates the Helm template golden fixture output to reflect the new image.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
mgmt-fixes/kubelet-ds.values.yaml Adds a chart value for the pinned runtime image used by the kubelet fix DaemonSet.
mgmt-fixes/deploy/kubelet-ds/templates/ds-kubelet-parameters.yaml Uses the values-provided pinned runtime image instead of alpine.
dev-infrastructure/zz_fixture_TestHelmTemplate_dev_westus3_mgmt_1_mgmt_fixes.yaml Updates rendered fixture to match the new DaemonSet image.

Comment thread mgmt-fixes/kubelet-ds.values.yaml Outdated
fi
sleep infinity
image: alpine
image: "{{ .Values.image }}"
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 10, 2026 23:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment thread mgmt-fixes/deploy/kubelet-ds/templates/ds-kubelet-parameters.yaml Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 10, 2026 23:56
@hlipsig hlipsig marked this pull request as draft July 10, 2026 23:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@hlipsig hlipsig marked this pull request as ready for review July 11, 2026 00:01
@openshift-ci openshift-ci Bot requested a review from avollmer-redhat July 11, 2026 00:01
@openshift-ci

openshift-ci Bot commented Jul 11, 2026

Copy link
Copy Markdown

@hlipsig: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration e76a45f link true /test integration
ci/prow/test-unit e76a45f link true /test test-unit
ci/prow/lint e76a45f link true /test lint
ci/prow/image-updater-images e76a45f link true /test image-updater-images
ci/prow/config-change-detection e76a45f link true /test config-change-detection
ci/prow/e2e-parallel e76a45f link true /test e2e-parallel
ci/prow/periodic-healthcheck-images e76a45f link true /test periodic-healthcheck-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants