Cache ItemStacks to improve performance#1249
Open
Swedz wants to merge 2 commits intoAztechMC:1.21.xfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simply caches
ItemStacks inConfigurableItemStackandSlotItemHandlerto reduce the unnecessary initializations. This should be safe, since the result ofIItemHandler#getStackInSlotmust not be modified.This also includes a very minor improvement in
ItemVariantImplthat reduces the unnecessary copying ofItemStacks - I'm not too sure that is contributing very much here though. This can be dropped if deemed unnecessary.Profile reports courtesy of PupleDino on discord:
Spark Report (Before)
Spark Report (After)
In this case, it seems to yield a roughly 10ms/t reduction.