Release v0.3.1#5
Merged
Merged
Conversation
The Google Fonts import only loaded wght 400/600/700 with no italic axis, so the Figma "Archivo Light Italic" captions (ArchiveProgress / ArchiveView / Search) were faux-synthesised. Load ital,wght 300/400/600/700 × normal+italic. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Release 0.3.0 components + the Figma fidelity audit fixes as v0.3.1. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the font import to include Archivo light (300) and corresponding italic variants to match Figma usage and bumps the package version to 0.3.1 for release tagging and automation. Flow diagram for release tagging and automation for v0.3.1flowchart LR
D[Developer] --> T[Create git tag v0.3.1]
T --> GHA[GitHub Actions release.yml]
GHA --> C[Verify tag matches package.json version 0.3.1]
C --> B[Build tarball]
B --> R[Publish GitHub Release with tarball]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider adding the
&display=swap(or another explicitdisplaymode) parameter to the Google Fonts URL so text rendering behavior is controlled and consistent across consumers of this package. - Given that this library is shared, you may want to clarify or centralize how consumers can override or disable the Google Fonts import (e.g., via a CSS variable or build-time flag) to avoid forcing these additional font weights/styles in environments that prefer self-hosting.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding the `&display=swap` (or another explicit `display` mode) parameter to the Google Fonts URL so text rendering behavior is controlled and consistent across consumers of this package.
- Given that this library is shared, you may want to clarify or centralize how consumers can override or disable the Google Fonts import (e.g., via a CSS variable or build-time flag) to avoid forcing these additional font weights/styles in environments that prefer self-hosting.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4, which merged at
b11645e— before these two commits landed.fix(fonts): load Archivo weight 300 + italic axis so the Figma "Light Italic" captions (ArchiveProgress/ArchiveView/Search) render real, not faux-synthesised.chore: bumppackage.jsonto 0.3.1.After merge, tag
v0.3.1on the merge commit → triggersrelease.yml(verifies tag matches package.json, builds, and publishes the GitHub Release with the tarball).🤖 Generated with Claude Code
Summary by Sourcery
Prepare v0.3.1 release with updated font styling and version metadata.
New Features:
Enhancements:
Build: