Skip to content

Fix/homogenize file check ui #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jansaldo merged 4 commits into from
May 22, 2026
Merged

Fix/homogenize file check ui #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb89e04
fix(spinner): add viewBox attribute to SVG for proper scaling
jansaldo May 20, 2026
079e2c8
fix(styles): homogenize maxWidth and dimensions for file check compon…
jansaldo May 20, 2026
e79c177
fix(components): change subtitle from h3 to h2 for consistency with p…
jansaldo May 20, 2026
a5b13a6
fix(file-check): add size prop to Text component for consistent styling
jansaldo May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 3 additions & 20 deletions src/renderer/src/components/file-check/FileCheck.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,7 @@ export const Wrapper = styled("div", {
position: "relative",

// Settings to enable ellipsis on file name
maxWidth: 131,
"@xl": {
maxWidth: 175,
},
maxWidth: 150,
"& p": {
overflow: "hidden",
textOverflow: "ellipsis",
Expand All @@ -30,22 +27,8 @@ export const Card = styled("div", {
justifyContent: "center",
alignItems: "center",

height: 150,
width: 113,

"@xl": {
height: 200,
width: 150,
"& svg": {
width: 48,
height: 48,
},
},

"& svg": {
width: 36,
height: 36,
},
height: 200,
width: 150,

borderWidth: "$sizes$xs",
borderStyle: "solid",
Expand Down
2 changes: 1 addition & 1 deletion src/renderer/src/components/file-check/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export default function FileCheck({
<Card {...{ hasError }}>
<Icon {...{ hasError, isLoading }} />
</Card>
<Text>{fileName}</Text>
<Text size="s">{fileName}</Text>
{hasError && <ErrorText>{errorMessage}</ErrorText>}
</Wrapper>
);
Expand Down
2 changes: 1 addition & 1 deletion src/renderer/src/components/finish/finish-main-content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export default function FinishMainContent({
</Stack>
<Card>
<Stack gap={{ base: "4", xl: "8" }}>
<styled.h3>{t("finish.subtitle")}</styled.h3>
<styled.h2 textStyle="subtitle.md.default">{t("finish.subtitle")}</styled.h2>

@sourcery-ai sourcery-ai Bot May 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Changing this from h3 to h2 could affect heading hierarchy and accessibility.

If there’s already an h1/h2 earlier on the page, this promotion could disrupt the logical heading order used by screen readers and in-page navigation. Please review the page’s overall outline; if this is mainly a visual change, consider keeping it as an h3 and applying textStyle="subtitle.md.default" via styling instead.

<Grid columns={4} gap="8" justifyContent="center" width="full">
{children}
</Grid>
Expand Down
2 changes: 1 addition & 1 deletion src/renderer/src/components/spinner/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const SVG = styled("svg", {

export default function Spinner() {
return (
<SVG width={48} height={48} fill="none" xmlns="http://www.w3.org/2000/svg">
<SVG width={48} height={48} viewBox="0 0 48 48" fill="none" xmlns="http://www.w3.org/2000/svg">
<path
d="M24 42c9.941 0 18-8.059 18-18S33.941 6 24 6 6 14.059 6 24s8.059 18 18 18Z"
stroke="#E6E8FF"
Expand Down