Conversation
There was a problem hiding this comment.
I just removed AllUsers="true" to make install easier for testing.
|
Could you please try to reduce the code duplication where possible? I think a ResourceDictionary might help here. |
|
Yes, I will keep that in mind moving forward. Thanks for the feedback. |
|
@alex-bochkov, I took the liberty of attempting to harmonize the tools window headings to match the GitHub sync window. I like the link to the wiki (see image in the top comment). |
|
I made 2 non-theme related changes. Both changes were on the schema compare window. 1) Lazy-load definitionsSchema compare previously built full source and target definition scripts for every difference row during compare completion. That behavior caused large memory/CPU spikes on big schemas and could freeze or crash SSMS before results rendered. The implementation now loads definition text only for the selected difference row (and on Copy actions), which keeps initial rendering responsive. 2) Synchronized definition scrollingThe Source Definition and Target Definition panes now synchronize vertical and horizontal scrolling. When one definition pane is scrolled, the other pane follows to the same offset so side-by-side review stays aligned. |




This PR adds theme support for all xaml windows.
Many windows were completely unusable in any of the dark themes that ssms offers such as
DarkandMoonlight GlowandMystical Forest.I also took the opportunity to sync up the style between windows while keeping the same feel of the extension.
Before
After