Skip to content

macOS: don't crash the process when bridge injection fails on a non-s… #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
szemeredipeter-prog wants to merge 1 commit into
base: main
Choose a base branch
from
Open

macOS: don't crash the process when bridge injection fails on a non-s… #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/Avalonia.Controls.WebView.Core/Macios/MaciosWebViewAdapter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,19 @@ private void OnDelegateOnDecidePolicyNavigation(object? _, WKNavigationDelegate.

private async void OnDelegateOnDidFinishNavigation(object? sender, EventArgs args)
{
_ = await InvokeScript(WebViewHelper.BuildWebKitInvokeCSharpActionScript(_scriptHandlerMessageName, stringify: true));
try
{
_ = await InvokeScript(WebViewHelper.BuildWebKitInvokeCSharpActionScript(_scriptHandlerMessageName, stringify: true));
}
catch (JavaScriptException)
{
// The just-finished navigation didn't load a scriptable HTML document (e.g. a file
// download, image, or PDF response) - EvaluateJavaScriptAsync then fails at the
Comment on lines +304 to +305

@maxkatz6 maxkatz6 Sep 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to detect common document types on which script cannot be executed.

And log error/warning when this "script invoke" failed. There might be situations, when this script call is expected, but exception would be silently ignored after this PR.

@maxkatz6 maxkatz6 Sep 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please write a more concise code comment, with more natural line breaks.
The longer comment the less people will actually read it in the future.

// native WebKit level and InvokeScript surfaces that as a JavaScriptException. That
// failure is not fatal on its own: the C#<->JS bridge simply isn't available for this
// particular navigation. Left unguarded, this exception previously escaped this
// async void event handler uncaught and crashed the whole process.
}

using var url = _webView.Url;
NavigationCompleted?.Invoke(this, new WebViewNavigationCompletedEventArgs { Request = Uri.TryCreate(url!.AbsoluteString, UriKind.Absolute, out var uri) ? uri : null, IsSuccess = true });
Expand Down