Add ordered adapter preferences - #77
Merged
Merged
Conversation
Applications may depend on capabilities that are only available from a particular WebView implementation, but backend-specific switches do not scale as more adapters and hosting modes are added. Expose a common ordered preference list on NativeWebView and NativeWebDialog. A non-empty list is exhaustive, allowing callers to express fallback order or require a single adapter, while an empty list preserves the existing platform defaults. Apply selection to WebView1 and WebView2 on Windows and to WPE WebKit and WebKitGTK on Linux. This also lets authentication callers select an adapter through the existing NativeWebDialogFactory without adding WebView-specific options to WebAuthenticatorOptions. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
maxkatz6
reviewed
Sep 2, 2026
maxkatz6
reviewed
Sep 2, 2026
Member
|
XAML compiler should be able to handle these enums as in |
Now that we have a general way to specify webview adapter preferences, we no longer need the specific WPE WebView 'PreferWebKitGtkInstead' flag on the environment requested event args. Mark this property as Obsolete with a hint to callers to use the new API 'AdapterPreference' on either the NativeWebView or NativeWebDialog. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
Remove the internal-only API to prefer using the WebView1 adapter for Windows (over WebView2) in favour of the generic 'AdapterPreference' ordered preference list on either NativeWebView or NativeWebDialog. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
maxkatz6
approved these changes
Sep 17, 2026
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applications may depend on capabilities that are only available from a particular WebView implementation, but backend-specific switches do not scale as more adapters and hosting modes are added.
Expose a common ordered preference list on NativeWebView and NativeWebDialog. A non-empty list is exhaustive, allowing callers to express fallback order or require a single adapter, while an empty list preserves the existing platform defaults.
Apply selection to WebView1 and WebView2 on Windows and to WPE WebKit and WebKitGTK on Linux. This also lets authentication callers select an adapter through the existing NativeWebDialogFactory without adding WebView-specific options to WebAuthenticatorOptions.
Example with
NativeWebDialogExample with
WebAuthenticationBrokerExample with
NativeWebViewvia code+XAMLExample with
NativeWebViewvia XAML-onlyThis is a proposal to address #16