Repository navigation
Revert Electron 44.7.1 bump (#6): workspace UI rename fails on hosted runners - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #6. After the merge, the main run failed three times in a row (38981391050 and its reruns) in scripts/test-workspace-ui.py at the tab rename step: the .tab-rename-input either never appears or is removed before the script can type into it. That assertion never failed on Electron 43 across today's eleven main runs, and it passes locally on VM106 under Electron 44 (full UI qualification 10/10, four repeats), so it is load dependent. The rename field saves on blur, so something steals focus from it on slow machines; the mechanism is not yet known. Restoring 43.7.7 keeps main green while Electron 44 is investigated on a branch. No source change other than the lockfile/package entries.