Repository navigation
test: give UI qualification runner tests a realistic script budget - #18
Merged
Merged
Conversation
execute() in test/run-ui-qualification.test.cjs ran every case with AUX_UI_SCRIPT_TIMEOUT=0.1, so the success and failure paths depended on a Python interpreter starting in under 100 ms. On busy hosted runners that flaked twice today (PR #11 and the main run for 631ce9c) with "fake-ui.py timed out after 0.1 seconds". Only the timeout cases keep the tight budget; everything else gets 30 s. A regression with a 300 ms script fails under the old helper and passes now. npm run check: 541/541.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The execute() helper in test/run-ui-qualification.test.cjs ran every case with AUX_UI_SCRIPT_TIMEOUT=0.1, so the success and failure paths depended on a Python interpreter starting within 100 ms. On busy hosted runners that flaked twice today (PR #11's first run and the main run for 631ce9c) with 'fake-ui.py timed out after 0.1 seconds'. Only the timeout cases keep the tight budget; everything else gets 30 s. A new regression runs a 300 ms script: it fails under the old helper and passes now. npm run check on VM106: 541 tests, 541 pass, 0 skipped. Test-only change.