feat(firmware): iec_runtime_fault glue + strucpp v0.5.8 - #882
Conversation
strucpp's new runtime (feat/iec-runtime-fault) calls iec_runtime_fault() on MCU targets (compiled -fno-exceptions) instead of throwing. Provide the weak default definition in the Arduino runtime glue: halt (for(;;)). VPP HALs may override it with a strong definition (e.g. P1AM blinks its LED). No -fexceptions change is needed in the editor — it never hardcoded it; the flag only came from VPP cxx_flags (removed separately in openplc-packages). NOTE: depends on the new strucpp runtime being bundled (the editor's resources/strucpp is sourced from an official strucpp release). Land after that release ships, alongside the VPP -fexceptions removals. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughThe Changesstrucpp Version Bump
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adopts strucpp v0.5.8 (target-aware runtime fault path).
strucpp::iec_runtime_fault(halt) for MCU targets compiled-fno-exceptions. VPP HALs may override (P1AM blinks its LED).v0.5.7→v0.5.8.No
-fexceptionschange here — the editor never hardcoded it (it came from VPPcxx_flags, removed in openplc-packages). Matching openplc-web PR opened with byte-identical firmware.🤖 Generated with Claude Code
Summary by CodeRabbit