Skip to content

feat(firmware): iec_runtime_fault glue + strucpp v0.5.8 - #882

Merged
thiagoralves merged 2 commits into
developmentfrom
feat/iec-runtime-fault-glue
Jun 16, 2026
Merged

feat(firmware): iec_runtime_fault glue + strucpp v0.5.8#882
thiagoralves merged 2 commits into
developmentfrom
feat/iec-runtime-fault-glue

Conversation

@thiagoralves

@thiagoralves thiagoralves commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Adopts strucpp v0.5.8 (target-aware runtime fault path).

  • arduino_runtime_glue.cpp: weak default strucpp::iec_runtime_fault (halt) for MCU targets compiled -fno-exceptions. VPP HALs may override (P1AM blinks its LED).
  • binary-versions.json: strucpp v0.5.7v0.5.8.

No -fexceptions change here — the editor never hardcoded it (it came from VPP cxx_flags, removed in openplc-packages). Matching openplc-web PR opened with byte-identical firmware.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated strucpp binary to version 0.5.8.

thiagoralves and others added 2 commits June 15, 2026 20:09
strucpp's new runtime (feat/iec-runtime-fault) calls iec_runtime_fault()
on MCU targets (compiled -fno-exceptions) instead of throwing. Provide the
weak default definition in the Arduino runtime glue: halt (for(;;)). VPP
HALs may override it with a strong definition (e.g. P1AM blinks its LED).

No -fexceptions change is needed in the editor — it never hardcoded it;
the flag only came from VPP cxx_flags (removed separately in openplc-packages).

NOTE: depends on the new strucpp runtime being bundled (the editor's
resources/strucpp is sourced from an official strucpp release). Land after
that release ships, alongside the VPP -fexceptions removals.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 092153c6-da3f-4fe6-8abd-130dc90822f3

📥 Commits

Reviewing files that changed from the base of the PR and between 8794068 and 92c2750.

⛔ Files ignored due to path filters (1)
  • resources/sources/arduino/arduino_runtime_glue.cpp is excluded by !resources/**
📒 Files selected for processing (1)
  • binary-versions.json

Walkthrough

The strucpp binary version entry in binary-versions.json is updated from v0.5.7 to v0.5.8. No other fields or entries in the file are modified.

Changes

strucpp Version Bump

Layer / File(s) Summary
strucpp version entry
binary-versions.json
The strucpp.version field is bumped from v0.5.7 to v0.5.8.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐇 A tiny hop, a single line,
The strucpp jumps from seven to eight so fine,
v0.5.8 now takes the stage,
A fresh new version on the page,
This bunny approves — change is divine! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description covers the main changes (strucpp upgrade, iec_runtime_fault implementation) but lacks structured information from the required template like References, DOD checklist sections. Add structured sections from the template: explicit issue/Jira references, and a completed DOD checklist to clarify testing and acceptance status.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title mentions 'iec_runtime_fault glue + strucpp v0.5.8', directly reflecting the main changes described in PR objectives and description.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/iec-runtime-fault-glue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thiagoralves
thiagoralves merged commit 9c69399 into development Jun 16, 2026
12 checks passed
@thiagoralves
thiagoralves deleted the feat/iec-runtime-fault-glue branch June 16, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant