fix: render web menu on Windows instead of hidden native menu - #727
Conversation
On Windows (and Linux), the native Electron menu is created with visible: false, but hasNativeMenu was always true — preventing the web MenuBar component from rendering. Detect macOS via navigator.platform and only set hasNativeMenu: true on macOS where the native menu is visible. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 45 minutes and 24 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughAdded macOS detection and exposed a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…issing file registration
getDefaultSchemaValues returned raw {} for ZodDefault wrapping ZodObject
instead of recursing into nested fields, causing a TypeError when accessing
communicationConfiguration.modbusRTU. Also replaced manual store hydration
in the create-project flow with handleOpenProjectResponse, which properly
registers files, flows, libraries, and opens the main POU tab.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
visible: falseinmenu.ts, butEDITOR_CAPABILITIES.hasNativeMenuwas alwaystrue— preventing the webMenuBarcomponent from rendering in the title bar.navigator.platformineditor-platform.tsand setshasNativeMenu: trueonly on macOS, where the native menu bar is actually visible.MenuBarand OpenPLC icon now render in the title bar's left slot.Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit