PHP 8.2: Fix Creation of dynamic property deprecation notices#153
Closed
philipjohn wants to merge 4 commits into
Closed
PHP 8.2: Fix Creation of dynamic property deprecation notices#153philipjohn wants to merge 4 commits into
philipjohn wants to merge 4 commits into
Conversation
|
Would be great to see this merged if possible to reduce a lot of chatter in the logs! |
|
A different PR that fixes the same issue has since been merged: #149 |
Member
|
Thanks for the PR @philipjohn, I apologise for the delay in feedback. It looks like these changes were merged in #149 and will be included in the 4.1 release via #162 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PHP 8.2, dynamically setting object properties that haven't been defined has been deprecated.
WP_Object_Cachedoes this in several places, leading to a number of these notices.The solution is simple - we simply need to define those properties in the class.