Skip to content

chore: remove deprecated npm-shrinkwrap.json - #2995

Draft
sjinks wants to merge 4 commits into
trunkfrom
kill-shrinkwrap
Draft

chore: remove deprecated npm-shrinkwrap.json#2995
sjinks wants to merge 4 commits into
trunkfrom
kill-shrinkwrap

Conversation

@sjinks

@sjinks sjinks commented Aug 3, 2026

Copy link
Copy Markdown
Member

From the npm changelog:

npm shrinkwrap is removed, the shrinkwrap config alias is removed, and npm-shrinkwrap.json is no longer loaded or honored at the project root or from inside dependency tarballs. Rename project-root npm-shrinkwrap.json to package-lock.json; use bundleDependencies if you need to ship a locked dependency tree.

This PR removes npm-shrinkwrap.json and instructs npm to bundle production dependencies into the dist archive.

@sjinks sjinks self-assigned this Aug 3, 2026
Copilot AI review requested due to automatic review settings August 3, 2026 22:43
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.
See the Details below.

License Issues

package.json

PackageVersionLicenseIssue Type
rxjs^7.8.2NullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
npm/graphql-ws 6.2.0 🟢 5.3
Details
CheckScoreReason
Code-Review🟢 4Found 12/27 approved changesets -- score normalized to 4
Maintained🟢 1016 commit(s) and 1 issue activity found in the last 90 days -- score normalized to 10
Binary-Artifacts🟢 10no binaries found in the repo
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Packaging⚠️ -1packaging workflow not detected
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Security-Policy⚠️ 0security policy file not detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md
Signed-Releases⚠️ -1no releases found
SAST🟢 8SAST tool detected but not run on all commits
npm/rxjs ^7.8.2 UnknownUnknown

Scanned Files

  • .github/workflows/sync-shrinkwrap.yml
  • package-lock.json
  • package.json

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the project’s dependency-locking/publish approach by removing the deprecated shrinkwrap sync tooling and switching to dependency bundling for distributed artifacts, aligning with npm v12+ behavior changes.

Changes:

  • Removed shrinkwrap sync scripts and added bundleDependencies configuration in package.json.
  • Updated package-lock.json to mark bundled dependencies (bundleDependencies list + inBundle flags).
  • Deleted the shrinkwrap sync helper and the associated GitHub Action workflow; removed the CI shrinkwrap check step.

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Removes shrinkwrap-related scripts and enables dependency bundling for packaging/publishing.
package-lock.json Records bundled dependency metadata (bundleDependencies and widespread inBundle annotations).
helpers/sync-shrinkwrap.js Deletes the shrinkwrap synchronization helper (no longer needed with npm v12+).
.github/workflows/sync-shrinkwrap.yml Removes the workflow that auto-synced npm-shrinkwrap.json on PRs.
.github/workflows/ci.yml Drops the shrinkwrap verification step from the CI matrix.

Comment thread package.json
@sonarqubecloud

sonarqubecloud Bot commented Aug 3, 2026

Copy link
Copy Markdown

@sjinks
sjinks marked this pull request as draft August 3, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants