Repository navigation
simplify colors no opacity - #634
Merged
Merged
Conversation
gpui-ce is turning element opacity into offscreen groups that defeat partial redraw, so disabled controls now paint computed colours instead of `.opacity(0.5)`. AppTheme::disabled_color halves a translucent colour's alpha and mixes an opaque one toward the panel surface. InteractionStyle::disabled_opacity becomes the opt-in dim_when_disabled plus InteractionStyle::color, so one style/state pair decides a control's fills, text, borders and icons. Button slots are a typed ButtonSlot (icon, spinner, keycaps, or a custom builder that receives the disabled state), so slot content dims with the button. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Button slots now ask the same InteractionStyle/state pair as the button's own colours, through the new InteractionStyle::dims, so one decision covers both. Test helpers share colour_close. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The update-check row locked by the environment used `.opacity(0.6)`. It is now a kit settings_disabled_toggle_row: a disabled interaction state whose label, separator, track and knob dim through the shared InteractionStyle colour, and which no longer shows a hover highlight. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gpui-ce turns any opacity below 1.0, zero included, into a viewport-sized offscreen group. The empty 1px carrier paints nothing without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The kit has no element opacity left; the app's remaining uses are listed by file and count, so a new one, or an entry nothing needs any more, fails a source guard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
production_sources stopped at the first `#[cfg(test)]\nmod tests`, including an out-of-line `mod tests;`, so the kit's source guards never saw the rest of about a dozen files. Both scanners now share production_text, which ends only at an inline test module. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The guard now also counts `Some` writes to an `opacity` field, names the gpui-ce change (#330) it guards against, groups the app's allowlist by reason, and runs over the terminal and media crates as well. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
InteractionStyle::apply sets the cursor on every path, so a `.cursor()` earlier in the same element's chain never takes effect. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Havunen
marked this pull request as ready for review
October 18, 2026 11:07
The gpui-ce bump re-resolved bindgen 0.73.2 onto syn 2 while its prettyplease 0.3 stays on syn 3. bindgen passes a syn::File between the two, so the macOS build failed with E0277. Linux never builds bindgen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Sampo Kivistö seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.