ci(security): audit hono and nestjs package.json changes - #43
Merged
Conversation
RobertoIskandarani
approved these changes
Jul 27, 2026
security.yml only re-ran npm audit on PRs touching sdk/mcp/fastmcp package.json. hono and nestjs ship too, so a PR changing only their dependencies would bypass the high/critical audit gate (the weekly scheduled run still covers the whole tree, but not per-PR). Add both package.json paths to the pull_request and push triggers for parity.
muralx
force-pushed
the
fix/security-audit-paths-hono-nestjs
branch
from
July 27, 2026 12:47
4c424d7 to
0acabdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
security.yml(the npm-audit gate) only triggers its per-PR / per-push run whensdk,mcp, orfastmcppackage.jsonchanges.honoandnestjswere added later and ship as published packages, but were never added to thepaths:filters — so a PR changing only their dependencies would merge without an audit check. (The weekly scheduled run audits the whole tree, so nothing is unaudited long-term; this closes the per-PR gap.)Change
Add
packages/hono/package.jsonandpackages/nestjs/package.jsonto both thepull_requestandpushpaths:lists. Workflow-only, no dependency changes.Note
Today both packages declare zero runtime dependencies (everything is
peerDependencies), so there is nothing for the audit to flag in their trees right now — this is parity/future-proofing so the gate fires if a runtime dep is ever added.Companion PR handles the actual high-severity advisories (axios/undici/fast-uri) in
fastmcp/mcp.