feat(tracker}: add Zenith (ZNTH) - #1389
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds ZNTH tracker support: new ChangesZNTH Tracker Integration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks for taking the time to contribute to this project. Upload Assistant is currently in a complete rewrite, and no new development is being conducted on this python source at this time. If you have come this far, please feel free to leave open, any pull requests regarding new sites being added to the source, as these can serve as the baseline for later conversion. If your pull request relates to a critical bug, this will be addressed in this code base, and a new release published as needed. If your pull request only addresses a quite minor bug, it is not likely to be addressed in this code base. Details for the new code base will follow at a later date. |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/trackers/ZNTH.py`:
- Around line 54-75: The parameter name `type` in async def get_type_id should
be renamed (e.g., to `content_type` or `torrent_type`) to avoid shadowing the
built-in; update the function signature and all internal references (`type` ->
`content_type`) and preserve the default value and existing logic (mapping_only,
reverse, and meta handling using meta.get('type')). Also search for and update
any external call sites that pass the keyword argument `type=` to use the new
parameter name to avoid breaking callers.
- Around line 40-42: The concatenation of meta.get('keywords') and
meta.get('combined_genres') into genres inserts a space not a CSV separator, so
the CSV-style regex in the adult detection can miss matches; update the genres
construction in src/trackers/ZNTH.py (where genres is set) to join only
non-empty parts with a comma (e.g., build a list [meta.get('keywords',''),
meta.get('combined_genres','')] filtered for truthy values and join with ', ')
so the existing regex and adult_keywords check work correctly; alternatively, if
you prefer to keep the current string join, adjust the regex left-boundary to
allow whitespace between lists, but prefer the comma-join fix for clarity.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3da56868-20da-4696-812f-8db0cb448cfb
📒 Files selected for processing (4)
data/example-config.pysrc/torrent_clients/qbittorrent.pysrc/trackers/ZNTH.pysrc/trackersetup.py
|
Thanks for your pr. The re-write is now live at https://github.com/autobrr/upbrr Your pr will be merged into upbrr with priority should it not be undertaken in the meantime. Thanks again. |
Sorry we're aware UA is on a dev freeze, but users wanted a better way to add the tracker.
Adds ZNTH a UNIT3D tracker: tracker class, registration, qB URL mapping, and example config. Banned-group endpoint returns plain strings, handled in write_banned_groups_to_file.
Summary by CodeRabbit
New Features
Documentation