Skip to content
This repository was archived by the owner on Jun 14, 2026. It is now read-only.

Add NOGROUP suffix if not disc for BHD - #1345

Open
glibbright wants to merge 3 commits into
Audionut:masterfrom
glibbright:bhd-nogroup
Open

Add NOGROUP suffix if not disc for BHD#1345
glibbright wants to merge 3 commits into
Audionut:masterfrom
glibbright:bhd-nogroup

Conversation

@glibbright

@glibbright glibbright commented Apr 21, 2026

Copy link
Copy Markdown

Adheres to rule 3.3.9. Technically they don't specify WEBRIP should have NOGROUP but I would be surprised if that was really the case, it's probably just missed off the rule.

Note this does not solve for rule 3.3.8 - that would require inspection of the folder names.

Summary by CodeRabbit

  • New Features
    • Torrent names now include an identifying suffix for items without tags that are not disc releases, enhancing library organization and discoverability.

Review Change Stack

@github-actions

Copy link
Copy Markdown

Thanks for taking the time to contribute to this project. Upload Assistant is currently in a complete rewrite, and no new development is being conducted on this python source at this time.

If you have come this far, please feel free to leave open, any pull requests regarding new sites being added to the source, as these can serve as the baseline for later conversion.

If your pull request relates to a critical bug, this will be addressed in this code base, and a new release published as needed.

If your pull request only addresses a quite minor bug, it is not likely to be addressed in this code base.

Details for the new code base will follow at a later date.

@Audionut

Copy link
Copy Markdown
Owner

The tag function itself will cover 3.3.8, I changed that handling in 25b5f09

In the context of 3.3.8 and 3.3.9, I think it's best to just exclude disc content, rather than including specific types.

@coderabbitai

coderabbitai Bot commented May 25, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2048abf8-affe-4090-a6b2-8366d25c30e1

📥 Commits

Reviewing files that changed from the base of the PR and between 3e39d5d and 1a42936.

📒 Files selected for processing (1)
  • src/trackers/BHD.py

📝 Walkthrough

Walkthrough

The BHD tracker's edit_name method now conditionally appends a -NOGROUP suffix to release names when a torrent lacks both a tag and disc designation, performing this suffix logic after existing DD+ to DDP normalization steps.

Changes

Release naming for untagged non-disc releases

Layer / File(s) Summary
-NOGROUP suffix logic in edit_name
src/trackers/BHD.py
After DD+ → DDP normalization, a conditional appends -NOGROUP to the final name when meta.get('tag') is falsy and meta.get('is_disc') is falsy.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

  • Audionut/Upload-Assistant#1210: Removed -NOGROUP behavior in src/trackers/DP.py's name generation; this PR mirrors that tag handling pattern by adding conditional -NOGROUP suffix logic to BHD tracker's release naming.

Poem

🐰 A fluffy suffix hops into place,
When tags and discs both leave no trace,
-NOGROUP marks the torrent's tale,
Our BHD tracker won't fail,
No naming details slip through the pace! 🎯

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately describes the main change: adding a NOGROUP suffix to BHD torrents when they are not discs, which is the core modification in the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@glibbright

Copy link
Copy Markdown
Author

@Audionut Sorry for long delay. Made the change to just check if not a disc.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants