Add NOGROUP suffix if not disc for BHD - #1345
Conversation
|
Thanks for taking the time to contribute to this project. Upload Assistant is currently in a complete rewrite, and no new development is being conducted on this python source at this time. If you have come this far, please feel free to leave open, any pull requests regarding new sites being added to the source, as these can serve as the baseline for later conversion. If your pull request relates to a critical bug, this will be addressed in this code base, and a new release published as needed. If your pull request only addresses a quite minor bug, it is not likely to be addressed in this code base. Details for the new code base will follow at a later date. |
|
The tag function itself will cover 3.3.8, I changed that handling in 25b5f09 In the context of 3.3.8 and 3.3.9, I think it's best to just exclude disc content, rather than including specific types. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe BHD tracker's ChangesRelease naming for untagged non-disc releases
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@Audionut Sorry for long delay. Made the change to just check if not a disc. |
Adheres to rule 3.3.9. Technically they don't specify WEBRIP should have
NOGROUPbut I would be surprised if that was really the case, it's probably just missed off the rule.Note this does not solve for rule 3.3.8 - that would require inspection of the folder names.
Summary by CodeRabbit