Refactor: consolidate duplicated code, use typed symbols, pin packages#5
Merged
Conversation
- Consolidate 3 glob/wildcard implementations into single GlobMatcher utility - Remove ToolUtils.GetContentDir duplication, fix env var bypass in GetRepoOutlineTool - Fix double ApplyExtraExtensions call in Program.cs - Extract WriteJsonAtomically helper and add GetSymbolContent overload in IndexStore - Add SearchWithScores to avoid re-scoring, cache GetSymbol results to avoid double lookup - Extract ResolveRepoOrError and BuildMeta helpers to reduce tool boilerplate - Pin all NuGet package versions (TreeSitter.DotNet 1.3.0, MAB.DotIgnore 3.0.2, etc.) - Replace List<Dictionary<string, JsonElement>> with List<Symbol> throughout CodeIndex - Delete JsonElementHelpers.cs (no longer needed with typed symbols) - All 109 tests passing, net reduction of ~320 lines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GlobMatcherutility classToolUtils.GetContentDir, fix env var bypass inGetRepoOutlineToolProgram.csWriteJsonAtomicallyfor atomic saves,GetSymbolContentoverload accepting pre-loaded indexSearchWithScoresavoids re-scoring, cachedGetSymbolresults avoid double lookupsResolveRepoOrErrorandBuildMetahelpers replace repeated try/catch and meta-building patterns across 8 toolsList<Dictionary<string, JsonElement>>withList<Symbol>throughoutCodeIndex, deleteJsonElementHelpers.csNet reduction of ~270 lines. All 109 tests passing.
Test plan
dotnet build— 0 errors, 0 warningsdotnet test— 109/109 tests passing